Skip to content

Conversation

@jedcunningham
Copy link
Member

With the remote commands being added to a separate distribution, we no longer need to distinguish between local and remote commands in core - they are all local commands!

With the remote commands being added to a separate distribution, we no
longer need to distinguish between local and remote commands in core -
they are all local commands!
@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:CLI area:dev-tools labels Mar 25, 2025
@jedcunningham jedcunningham added the AIP-81 Enhanced Security in CLI via Integration of API label Mar 25, 2025
@jedcunningham jedcunningham requested a review from bugraoz93 March 25, 2025 04:31
Copy link
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great! Many thanks for the changes, Jed! This was on my to-do list, but I couldn't find the time to make it happen.

There is one small place to update. After this, we should be good

files_not_fully_covered = [
"airflow/cli/cli_config.py",
"airflow/cli/cli_parser.py",
"airflow/cli/commands/remote_commands/config_command.py",
"airflow/cli/commands/remote_commands/connection_command.py",
"airflow/cli/commands/remote_commands/dag_command.py",
"airflow/cli/commands/local_commands/dag_processor_command.py",
"airflow/cli/commands/local_commands/db_command.py",
"airflow/cli/commands/local_commands/info_command.py",
"airflow/cli/commands/remote_commands/jobs_command.py",
"airflow/cli/commands/local_commands/plugins_command.py",
"airflow/cli/commands/remote_commands/pool_command.py",
"airflow/cli/commands/remote_commands/provider_command.py",
"airflow/cli/commands/local_commands/scheduler_command.py",
"airflow/cli/commands/local_commands/standalone_command.py",
"airflow/cli/commands/remote_commands/task_command.py",
"airflow/cli/commands/remote_commands/variable_command.py",
"airflow/cli/simple_table.py",
]

@bugraoz93
Copy link
Contributor

I believe this CI faluire is fixed in there #48249

@jedcunningham
Copy link
Member Author

Thanks @bugraoz93, I must have only been searching in airflow-core, only way I can think I missed those 🤦.

Copy link
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including @jedcunningham! Too many files :D

@jedcunningham jedcunningham merged commit 6f76326 into apache:main Mar 25, 2025
89 checks passed
@jedcunningham jedcunningham deleted the flatten_cli_commands branch March 25, 2025 19:22
pankajkoti pushed a commit to astronomer/airflow that referenced this pull request Mar 28, 2025
With the remote commands being added to a separate distribution, we no
longer need to distinguish between local and remote commands in core -
they are all local commands!
shubham-pyc pushed a commit to shubham-pyc/airflow that referenced this pull request Apr 2, 2025
With the remote commands being added to a separate distribution, we no
longer need to distinguish between local and remote commands in core -
they are all local commands!
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
With the remote commands being added to a separate distribution, we no
longer need to distinguish between local and remote commands in core -
they are all local commands!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AIP-81 Enhanced Security in CLI via Integration of API area:API Airflow's REST/HTTP API area:CLI area:dev-tools

Development

Successfully merging this pull request may close these issues.

3 participants