-
Notifications
You must be signed in to change notification settings - Fork 16.3k
AIP-81: Flatten core CLI commands #48224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
With the remote commands being added to a separate distribution, we no longer need to distinguish between local and remote commands in core - they are all local commands!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great! Many thanks for the changes, Jed! This was on my to-do list, but I couldn't find the time to make it happen.
There is one small place to update. After this, we should be good
airflow/scripts/cov/cli_coverage.py
Lines 30 to 48 in c3b21b7
| files_not_fully_covered = [ | |
| "airflow/cli/cli_config.py", | |
| "airflow/cli/cli_parser.py", | |
| "airflow/cli/commands/remote_commands/config_command.py", | |
| "airflow/cli/commands/remote_commands/connection_command.py", | |
| "airflow/cli/commands/remote_commands/dag_command.py", | |
| "airflow/cli/commands/local_commands/dag_processor_command.py", | |
| "airflow/cli/commands/local_commands/db_command.py", | |
| "airflow/cli/commands/local_commands/info_command.py", | |
| "airflow/cli/commands/remote_commands/jobs_command.py", | |
| "airflow/cli/commands/local_commands/plugins_command.py", | |
| "airflow/cli/commands/remote_commands/pool_command.py", | |
| "airflow/cli/commands/remote_commands/provider_command.py", | |
| "airflow/cli/commands/local_commands/scheduler_command.py", | |
| "airflow/cli/commands/local_commands/standalone_command.py", | |
| "airflow/cli/commands/remote_commands/task_command.py", | |
| "airflow/cli/commands/remote_commands/variable_command.py", | |
| "airflow/cli/simple_table.py", | |
| ] |
|
I believe this CI faluire is fixed in there #48249 |
|
Thanks @bugraoz93, I must have only been searching in |
bugraoz93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for including @jedcunningham! Too many files :D
With the remote commands being added to a separate distribution, we no longer need to distinguish between local and remote commands in core - they are all local commands!
With the remote commands being added to a separate distribution, we no longer need to distinguish between local and remote commands in core - they are all local commands!
With the remote commands being added to a separate distribution, we no longer need to distinguish between local and remote commands in core - they are all local commands!
With the remote commands being added to a separate distribution, we no longer need to distinguish between local and remote commands in core - they are all local commands!