-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fix asset materialize CLI command #48391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix asset materialize CLI command #48391
Conversation
Lee-W
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wondering whether there's a way to test this 🤔
| name="materialize", | ||
| help="Materialize an asset", | ||
| func=lazy_load_command("airflow.cli.commands.asset_command.asset_materialize"), | ||
| func=lazy_load_command("airflow.cli.commands.remote_commands.asset_command.asset_materialize"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now flat in airflow-core, where all commands are under airflow-core/cli/commands. It was before like this remote_commands and local_commands. Now the split is more on airflowctl containing remote and airflow containing local commands. Everything is moved in here: #48224. Let me check too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh didn't notice it. I guess that means we probably don't need this one? @vatsrahul1001 could you please test it out and see whether it works well in main already? Thanks!
jedcunningham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we should be good to go without this now - working for me too. Thanks for the PR though @vatsrahul1001.


closes: #48382
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.