Skip to content

Conversation

@RulerChen
Copy link
Contributor

fix #48619


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Apr 2, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@RulerChen RulerChen changed the title fix provider icon url Fix discord and slack provider icon url Apr 2, 2025
Copy link
Contributor

@DjVinnii DjVinnii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this image moved to airflow-core/src/airflow/ui/public?

@RulerChen
Copy link
Contributor Author

RulerChen commented Apr 2, 2025

Isn't this image moved to airflow-core/src/airflow/ui/public?

I only see pin_32.png in there. I think the image size is a little bit different, or do I need to push pin_100.png there?

@eladkal eladkal force-pushed the fix/provider-icon-url branch from d251594 to dc2c721 Compare April 3, 2025 07:59
@RulerChen
Copy link
Contributor Author

Hi, @eladkal. I have replaced all the URLs I found with the correct ones. Please take a look again. Thanks!

@eladkal eladkal merged commit 6c885cd into apache:main Apr 6, 2025
65 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 6, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@RulerChen RulerChen deleted the fix/provider-icon-url branch April 6, 2025 14:40
diogotrodrigues pushed a commit to diogotrodrigues/airflow that referenced this pull request Apr 6, 2025
* fix provider icon url

---------

Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
simonprydden pushed a commit to simonprydden/airflow that referenced this pull request Apr 8, 2025
* fix provider icon url

---------

Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

discord notification avatar_url is no longer valid

4 participants