-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Fix discord and slack provider icon url #48680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
DjVinnii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this image moved to airflow-core/src/airflow/ui/public?
I only see |
providers/discord/src/airflow/providers/discord/notifications/discord.py
Outdated
Show resolved
Hide resolved
providers/discord/src/airflow/providers/discord/notifications/discord.py
Outdated
Show resolved
Hide resolved
d251594 to
dc2c721
Compare
|
Hi, @eladkal. I have replaced all the URLs I found with the correct ones. Please take a look again. Thanks! |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* fix provider icon url --------- Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
* fix provider icon url --------- Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
fix #48619
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.