Skip to content

Fix discord and slack provider icon url #48680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eladkal merged 11 commits into from
Apr 6, 2025
Merged

Fix discord and slack provider icon url #48680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
dd63382
fix provider icon url
RulerChen Apr 2, 2025
e29c4c5
Merge branch 'main' into fix/provider-icon-url
RulerChen Apr 2, 2025
cebc8f7
Merge branch 'main' into fix/provider-icon-url
RulerChen Apr 2, 2025
c0a052c
fix provider icon url
RulerChen Apr 2, 2025
dc2c721
update image link
eladkal Apr 3, 2025
99e4a09
Merge branch 'main' into fix/provider-icon-url
RulerChen Apr 3, 2025
5f6a182
add image and change url
RulerChen Apr 3, 2025
effc45f
Merge branch 'fix/provider-icon-url' of https://github.com/RulerChen/…
RulerChen Apr 3, 2025
55416c6
Merge branch 'main' into fix/provider-icon-url
RulerChen Apr 3, 2025
49d54c4
run ruff format
RulerChen Apr 3, 2025
6b3005b
Merge branch 'main' into fix/provider-icon-url
RulerChen Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion providers/discord/src/airflow/providers/discord/notifications/discord.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@
from airflow.providers.common.compat.notifier import BaseNotifier
from airflow.providers.discord.hooks.discord_webhook import DiscordWebhookHook

ICON_URL: str = "https://raw.githubusercontent.com/apache/airflow/main/airflow/www/static/pin_100.png"
ICON_URL: str = (
"https://raw.githubusercontent.com/apache/airflow/main/airflow-core/src/airflow/ui/public/pin_100.png"
)


class DiscordNotifier(BaseNotifier):
Expand Down
4 changes: 3 additions & 1 deletion providers/slack/src/airflow/providers/slack/notifications/slack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@
if TYPE_CHECKING:
from slack_sdk.http_retry import RetryHandler

ICON_URL: str = "https://raw.githubusercontent.com/apache/airflow/2.5.0/airflow/www/static/pin_100.png"
ICON_URL: str = (
"https://raw.githubusercontent.com/apache/airflow/main/airflow-core/src/airflow/ui/public/pin_100.png"
)


class SlackNotifier(BaseNotifier):
Expand Down
2 changes: 1 addition & 1 deletion providers/slack/src/airflow/providers/slack/operators/slack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def __init__(
"https://www.youtube.com/watch?v=J---aiyznGQ"
),
icon_url: str = (
"https://raw.githubusercontent.com/apache/airflow/main/airflow/www/static/pin_100.png"
"https://raw.githubusercontent.com/apache/airflow/main/airflow-core/src/airflow/ui/public/pin_100.png"
),
blocks: list | None = None,
attachments: list | None = None,
Expand Down
4 changes: 3 additions & 1 deletion providers/slack/tests/system/slack/example_slack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@
DAG_ID = "slack_api_example_dag"
SLACK_API_CONN_ID = os.environ.get("SLACK_API_CONN_ID", "slack_conn_id")
SLACK_CHANNEL = os.environ.get("SLACK_CHANNEL", "#general")
IMAGE_URL = "https://raw.githubusercontent.com/apache/airflow/main/airflow/www/static/pin_100.png"
IMAGE_URL = (
"https://raw.githubusercontent.com/apache/airflow/main/airflow-core/src/airflow/ui/public/pin_100.png"
)

with DAG(
dag_id=DAG_ID,
Expand Down
4 changes: 3 additions & 1 deletion providers/slack/tests/system/slack/example_slack_webhook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@
ENV_ID = os.environ.get("SYSTEM_TESTS_ENV_ID")
DAG_ID = "slack_webhook_example_dag"
SLACK_WEBHOOK_CONN_ID = os.environ.get("SLACK_WEBHOOK_CONN_ID", "slack_default")
IMAGE_URL = "https://raw.githubusercontent.com/apache/airflow/main/airflow/www/static/pin_100.png"
IMAGE_URL = (
"https://raw.githubusercontent.com/apache/airflow/main/airflow-core/src/airflow/ui/public/pin_100.png"
)

with DAG(
dag_id=DAG_ID,
Expand Down
16 changes: 8 additions & 8 deletions providers/slack/tests/unit/slack/notifications/test_slack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ def test_slack_notifier(self, mock_slack_hook, dag_maker, extra_kwargs, hook_ext
"channel": "#general",
"username": "Airflow",
"text": "test",
"icon_url": "https://raw.githubusercontent.com/apache/airflow/2.5.0/airflow/www/static"
"/pin_100.png",
"icon_url": "https://raw.githubusercontent.com/apache/airflow/main/airflow-core"
"/src/airflow/ui/public/pin_100.png",
"attachments": "[]",
"blocks": "[]",
"unfurl_links": True,
Expand All @@ -87,8 +87,8 @@ def test_slack_notifier_with_notifier_class(self, mock_slack_hook, dag_maker):
"channel": "#general",
"username": "Airflow",
"text": "test",
"icon_url": "https://raw.githubusercontent.com/apache/airflow/2.5.0/airflow/www/static"
"/pin_100.png",
"icon_url": "https://raw.githubusercontent.com/apache/airflow/main/airflow-core"
"/src/airflow/ui/public/pin_100.png",
"attachments": "[]",
"blocks": "[]",
"unfurl_links": True,
Expand All @@ -114,8 +114,8 @@ def test_slack_notifier_templated(self, mock_slack_hook, dag_maker):
"channel": "#test-test_slack_notifier",
"username": "Airflow",
"text": "test Airflow",
"icon_url": "https://raw.githubusercontent.com/apache/airflow/2.5.0/airflow/www/static"
"/pin_100.png",
"icon_url": "https://raw.githubusercontent.com/apache/airflow/main/airflow-core"
"/src/airflow/ui/public/pin_100.png",
"attachments": '[{"image_url": "test_slack_notifier.png"}]',
"blocks": "[]",
"unfurl_links": True,
Expand All @@ -140,8 +140,8 @@ def test_slack_notifier_unfurl_options(self, mock_slack_hook, dag_maker):
"channel": "#general",
"username": "Airflow",
"text": "test",
"icon_url": "https://raw.githubusercontent.com/apache/airflow/2.5.0/airflow/www/static"
"/pin_100.png",
"icon_url": "https://raw.githubusercontent.com/apache/airflow/main/airflow-core"
"/src/airflow/ui/public/pin_100.png",
"attachments": "[]",
"blocks": "[]",
"unfurl_links": False,
Expand Down
2 changes: 1 addition & 1 deletion providers/slack/tests/unit/slack/operators/test_slack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ def test_api_call_params_with_default_args(self, mock_hook):
"Here is a cat video instead\n"
"https://www.youtube.com/watch?v=J---aiyznGQ",
"icon_url": "https://raw.githubusercontent.com/apache/"
"airflow/main/airflow/www/static/pin_100.png",
"airflow/main/airflow-core/src/airflow/ui/public/pin_100.png",
"attachments": "[]",
"blocks": "[]",
}
Expand Down