-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Remove Openlineage from list of pre-installed providers #48947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we should add newsfragment about it - it changes the behaviour of pip install apache-airflow
OL wasn't installed in 2.10.x though |
|
Newsfragment - when it comes to SQLite at least. Also it might break lowest dependency tests for Airflow core - I believe one reason I added it was that Airflow core was at that time some tests or even all tests failed. Maybe things changed since, but I think not. Let's see how it works, but:
|
|
Yeah - the first failure is |
|
(And let's see what fails next) |
|
Correct me if I am wrong but we removed |
Yeah that's done. But even that does not need anything in the Sqlite provider to work. It just has: airflow/providers/sqlite/pyproject.toml Lines 59 to 63 in 89df9fc
|
Not everyone will want OL installed.
e86b05d to
d2060c2
Compare
|
Separating Sqlite removal to separate PR |
@eladkal Not true anymore, I fixed it a few months back. |
|
in #44839 |
|
The sqlite provider was never technically needed to use SQLite as meta-data. Those two have nothing to do with each other - provider simply create a DBAPI Hook so that SQLite (but not the one that has airflow metadata) can be used via common.sql operators. The SQlite database is part of stdlib and the only depedency extra it has is "aiosqlite" -> Which BTW I think this is somewhat wrong - aiosqlite should be added to the core. I commented it in #48950 |
Not everyone will want OL installed.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.