Skip to content

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Apr 8, 2025

Sqlite provider just has 1 hook and isn't needed for LocalExecutor to work with Sqlite.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Sqlite provider just has 1 hook and isn't needed for `LocalExecutor` to work with Sqlite.
@kaxil kaxil requested review from eladkal and potiuk April 8, 2025 15:32
@potiuk
Copy link
Member

potiuk commented Apr 8, 2025

Actually I think it is not the best way - I looked more closely - and aiosqlite that is dependency of the SQLite provider is actually not used in the provider, it is used in core (in the future) for getting the asynchronous connection. We are not using it now, it was more of an experiment by @dstandish and we were planning to progress with it after 3.0.

SO the right way of fixing it is to add another core-dependency aiosqlite that will not have a provider it will just add the async capability to airflow core.

@potiuk
Copy link
Member

potiuk commented Apr 8, 2025

I can open another request for that @kaxil

@potiuk
Copy link
Member

potiuk commented Apr 8, 2025

Actually - not even that. I believe Airflow now needs aiosqlite whenever SQLite connection is used @dstandish - because it will always attempt to create the sqlite async engine. So we really need to make aiosqlite a required dependency for airflow IMHO

@potiuk
Copy link
Member

potiuk commented Apr 8, 2025

Alternative in #48966 -> we need to keep aiosqlite in core.

@potiuk potiuk closed this Apr 8, 2025
@potiuk
Copy link
Member

potiuk commented Apr 8, 2025

Closing this one.

@kaxil kaxil deleted the remove-sqlite branch December 31, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants