Skip to content

Conversation

@gopidesupavan
Copy link
Member

As discussed here, the #48819 (comment) and #48819 (comment) we need to consider all tasks in each task group to verify the success criteria condition.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@gopidesupavan
Copy link
Member Author

I dont think any other option otherwise a new complete endpoint to be added, so i feel simplest one is to add new return_task_group_count param to endpoint, to return task_group count.

@gopidesupavan
Copy link
Member Author

image

@kaxil
Copy link
Member

kaxil commented Apr 10, 2025

I dont think any other option otherwise a new complete endpoint to be added, so i feel simplest one is to add new return_task_group_count param to endpoint, to return task_group count.

I think new endpoint is better -- so that we can follow single responsibility principle

@gopidesupavan
Copy link
Member Author

I dont think any other option otherwise a new complete endpoint to be added, so i feel simplest one is to add new return_task_group_count param to endpoint, to return task_group count.

I think new endpoint is better -- so that we can follow single responsibility principle

alright , will update then..thanks

@gopidesupavan
Copy link
Member Author

post change:

image

@gopidesupavan gopidesupavan merged commit ef80791 into apache:main Apr 11, 2025
95 checks passed
@gopidesupavan gopidesupavan deleted the fix-task-group-logic branch April 11, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants