-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Fix ExternalTaskSensor task_group_id check condition #49027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ExternalTaskSensor task_group_id check condition #49027
Conversation
|
I dont think any other option otherwise a new complete endpoint to be added, so i feel simplest one is to add new |
1889ddc to
cc87a35
Compare
I think new endpoint is better -- so that we can follow single responsibility principle |
alright , will update then..thanks |
749e580 to
416fc96
Compare
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py
Outdated
Show resolved
Hide resolved
d3ddc56 to
f3f93bf
Compare
airflow-core/tests/unit/api_fastapi/execution_api/versions/head/test_task_instances.py
Outdated
Show resolved
Hide resolved
airflow-core/tests/unit/api_fastapi/execution_api/versions/head/test_task_instances.py
Outdated
Show resolved
Hide resolved
airflow-core/tests/unit/api_fastapi/execution_api/versions/head/test_task_instances.py
Outdated
Show resolved
Hide resolved
…d/test_task_instances.py Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
…d/test_task_instances.py Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
…d/test_task_instances.py Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
275036b to
75e3c6c
Compare


As discussed here, the #48819 (comment) and #48819 (comment) we need to consider all tasks in each task group to verify the success criteria condition.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.