Fix WorkflowTrigger to work with TaskSDK #48819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Member
Author
1 task
gopidesupavan
force-pushed
the
fix-workflow-trigger-deferrabe
branch
from
e23fd4a to
f56c92c
Compare
Member
Author
|
Also this is ready for review.. |
ashb
reviewed
Apr 7, 2025
Member
|
@gopidesupavan Could you resolve the coflicts please? |
gopidesupavan
force-pushed
the
fix-workflow-trigger-deferrabe
branch
from
27382f3 to
54d8231
Compare
Member
Author
Yeah rebased now.. |
kaxil
reviewed
Apr 8, 2025
providers/standard/src/airflow/providers/standard/sensors/external_task.py
Outdated
Show resolved
Hide resolved
kaxil
reviewed
Apr 8, 2025
providers/standard/src/airflow/providers/standard/triggers/external_task.py
Show resolved
Hide resolved
gopidesupavan
force-pushed
the
fix-workflow-trigger-deferrabe
branch
2 times, most recently
from
583c828 to
b02352e
Compare
kaxil
reviewed
Apr 9, 2025
providers/standard/src/airflow/providers/standard/sensors/external_task.py
Show resolved
Hide resolved
kaxil
approved these changes
Apr 9, 2025
Member
kaxil
left a comment
kaxil
left a comment
There was a problem hiding this comment.
Not sure of the task group thing, rest lgtm
kaxil
force-pushed
the
fix-workflow-trigger-deferrabe
branch
from
b02352e to
177234d
Compare
Member
|
(I rebased on main since the failures are fixed in main already I think) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #48425
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.