Skip to content

Conversation

@dstandish
Copy link
Contributor

Make it so we don't need to define a git connection for a git dag bundle.

Copy link
Contributor

@ephraimbuddy ephraimbuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of making GitDagBundle not to require a connection, how about creating an entire class that people can use if they don't want to use connection? We can rename GitDagBundle to reflect that it requires a connection and name the new bundle to reflect that it doesn't need it. This will make GitDagBundle consistent with how we design operators or anything that needs a connection by keeping a default connection ID

@ashb
Copy link
Member

ashb commented Apr 15, 2025

I'm not too familiar with the bundle backends, but having a separate class seems like an odd UX decision.

One of the reasons for wanting to make it optional is so that you can either:

  • Point your git bundle at a public repo for easy demo/onboarding; or
  • Make use of an existing SSH key on your machine.

In some ways it's similar to the AWS Hook, where if you don't configure it it will try and use instance identity out of the box, or what ever other configs it can find on the host. Which is also how git CLI works. I'd say we should be similar to that.

@dstandish dstandish force-pushed the make-it-optional-to-use-git-conn-for-git-bundle branch from ef9d0b2 to 0535232 Compare April 15, 2025 16:35
@kaxil kaxil merged commit 2c7b56e into apache:main Apr 15, 2025
61 checks passed
@kaxil kaxil deleted the make-it-optional-to-use-git-conn-for-git-bundle branch April 15, 2025 16:57
kaxil added a commit to astronomer/airflow that referenced this pull request Apr 15, 2025
This started failing after apache#49270 was merged
kaxil added a commit that referenced this pull request Apr 15, 2025
This started failing after #49270 was merged
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request May 29, 2025
This started failing after apache/airflow#49270 was merged

GitOrigin-RevId: 32b3f7cee6d3f3945b215b070c82341b31341c04
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 25, 2025
This started failing after apache/airflow#49270 was merged

GitOrigin-RevId: 32b3f7cee6d3f3945b215b070c82341b31341c04
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 22, 2025
This started failing after apache/airflow#49270 was merged

GitOrigin-RevId: 32b3f7cee6d3f3945b215b070c82341b31341c04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants