Skip to content

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Apr 15, 2025

This started failing after #49270 was merged

Example failure: https://github.com/apache/airflow/actions/runs/14475334372/job/40599982053?pr=49306


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

This started failing after apache#49270 was merged
@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Apr 15, 2025
@kaxil kaxil requested a review from dstandish April 15, 2025 18:08
@kaxil
Copy link
Member Author

kaxil commented Apr 15, 2025

Yolo again sry!

@kaxil kaxil merged commit 32b3f7c into apache:main Apr 15, 2025
17 checks passed
@kaxil kaxil deleted the fix-tests branch April 15, 2025 18:11
dstandish added a commit to astronomer/airflow that referenced this pull request Apr 15, 2025
kaxil added a commit to astronomer/airflow that referenced this pull request Apr 16, 2025
kaxil added a commit to astronomer/airflow that referenced this pull request Apr 16, 2025
kaxil added a commit that referenced this pull request Apr 16, 2025
* Use 'git_default' if the user defines nothing

When using a GitDagBundle, the user should tell us where the git repo is
by either repo_url or git_conn_id. If the user provides neither, try to
find a Connection named 'git_default' instead of failing directly.

If repo_url is provided, we won't try to find any Connection.

* Revert "Fix failing git bundle tests (#49313)"

This reverts commit 32b3f7c.

* Fix test

---------

Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
dstandish added a commit to astronomer/airflow that referenced this pull request Apr 16, 2025
These were removed due to a change which made using an Airflow connection optional in git dag bundle.
dstandish added a commit to astronomer/airflow that referenced this pull request Apr 16, 2025
These were removed due to a change which made using an Airflow connection optional in git dag bundle.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants