Use 'git_default' if the user defines nothing #49359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstandish
approved these changes
Apr 16, 2025
vatsrahul1001
approved these changes
Apr 16, 2025
uranusjr
force-pushed
the
default-to-git-default-if-nothing-provided
branch
2 times, most recently
from
abde9f8 to
be8102e
Compare
kaxil
force-pushed
the
default-to-git-default-if-nothing-provided
branch
from
f0e2628 to
af3345a
Compare
bugraoz93
approved these changes
Apr 16, 2025
potiuk
approved these changes
Apr 16, 2025
When using a GitDagBundle, the user should tell us where the git repo is by either repo_url or git_conn_id. If the user provides neither, try to find a Connection named 'git_default' instead of failing directly. If repo_url is provided, we won't try to find any Connection.
This reverts commit 32b3f7c.
Member
Author
|
Something’s wrong with dependencies… |
kaxil
force-pushed
the
default-to-git-default-if-nothing-provided
branch
from
af3345a to
2c475e4
Compare
Member
|
Jarek & I tested it, we are going YOLO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a GitDagBundle, the user should tell us where the git repo is by either repo_url or git_conn_id. If the user provides neither, try to find a Connection named 'git_default' instead of failing directly.
If repo_url is provided, we won't try to find any Connection.