Skip to content

update deprecated functions to use the stable functions #49340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eladkal wants to merge 1 commit into from
Closed

update deprecated functions to use the stable functions #49340

eladkal wants to merge 1 commit into from

Conversation

@eladkal
Copy link
Contributor

@eladkal eladkal commented Apr 16, 2025

We should use the functions that we ask users to migrate to

cc @guan404ming

@eladkal eladkal requested review from Lee-W, amoghrajesh and kaxil April 16, 2025 08:57
@guan404ming
Copy link
Member

guan404ming commented Apr 16, 2025 •
edited
Loading

Ref: #48875 (comment)

Since the new get_df return merged type, I choose to use private func keep identical type here which I thought could prevent to broke user’s type checker.

@eladkal
Copy link
Contributor Author

eladkal commented Apr 19, 2025

yeah. lets leave it as is

@eladkal eladkal closed this Apr 19, 2025
@eladkal eladkal deleted the sql branch April 19, 2025 17:54
@guan404ming guan404ming mentioned this pull request May 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lee-W Lee-W Lee-W approved these changes

@kaxil kaxil kaxil approved these changes

@amoghrajesh amoghrajesh amoghrajesh approved these changes

Assignees

No one assigned

Labels

area:providers provider:common-sql

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eladkal @guan404ming @Lee-W @kaxil @amoghrajesh