Refine type overload for common-sql
#50161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guan404ming
force-pushed
the
type-common-sql
branch
from
4405586 to
6ac8f76
Compare
eladkal
approved these changes
May 4, 2025
Member
Author
|
Thanks for the review. |
31 tasks
Member
Author
Contributor
|
@guan404ming feel free to raise PR |
mvfc
pushed a commit
to mvfc/airflow
that referenced
this pull request
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
get_pandas_dftoget_dfinproviders#49334BaseSqlToSlackOperatorto useget_df#50143 (comment)cc: @eladkal
Why
get_df,get_df_by_chunkswould return union df type for pandas and polars which would make type annotation in each providers mess.How
Overload type definition to return pandas dataframe when "pandas" is passed and also the polars one.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.