Migrate BaseSqlToSlackOperator to use get_df
#50143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
guan404ming
force-pushed
the
migrate-slack-transfer
branch
2 times, most recently
from
9243491 to
0c10fbe
Compare
eladkal
reviewed
May 4, 2025
providers/slack/src/airflow/providers/slack/transfers/base_sql_to_slack.py
Outdated
Show resolved
Hide resolved
guan404ming
force-pushed
the
migrate-slack-transfer
branch
2 times, most recently
from
cc0f366 to
01d1256
Compare
Member
Author
|
Worked in local, but dead in ci. Currently diagnosing. |
guan404ming
force-pushed
the
migrate-slack-transfer
branch
from
01d1256 to
0644120
Compare
Member
Author
|
Mypy run successfully here as well 🎉 |
guan404ming
changed the title
Slack/transfer to use get_dfBaseSqlToSlackOperator to use get_df
eladkal
reviewed
May 8, 2025
providers/slack/src/airflow/providers/slack/transfers/base_sql_to_slack.py
Show resolved
Hide resolved
eladkal
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
get_pandas_dftoget_dfinproviders#49334cc: @potiuk @eladkal
Why
get_pandas_dfdeprecated in #48875, which would be replaced byget_df. Thus, we need to migrate them in providers.How
Slack/transferNote
There is some workaround for type here. It should be removed after the common-sql bundle the refined type definition. I've added the TODO in the comment and would get back here after the release.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.