Skip to content

Conversation

@guan404ming
Copy link
Member

@guan404ming guan404ming commented May 6, 2025

Related Issue

#50161

Why

Since we now have more robust type definition, we could use the public functions instead of private functions without breaking the type check for deprecated functions, which ensures backward compatibility and follows a better coding style.

How

  • replace private functions with public functions for deprecated functions
  • minor changes: add default df_type test for get_df

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
@guan404ming guan404ming marked this pull request as ready for review May 6, 2025 18:44
@guan404ming guan404ming requested a review from eladkal as a code owner May 6, 2025 18:44
@eladkal eladkal merged commit 2bd2007 into apache:main May 8, 2025
78 of 104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants