Skip to content

Update deprecated functions to use stable functions #50275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eladkal merged 1 commit into from
May 8, 2025
Merged

Update deprecated functions to use stable functions #50275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ def get_pandas_df(
:param parameters: The parameters to render the SQL query with.
:param kwargs: (optional) passed into pandas.io.sql.read_sql method
"""
return self._get_pandas_df(sql, parameters, **kwargs)
return self.get_df(sql, parameters, df_type="pandas", **kwargs)

@deprecated(
reason="Replaced by function `get_df_by_chunks`.",
Expand All @@ -414,7 +414,7 @@ def get_pandas_df_by_chunks(
chunksize: int,
**kwargs,
) -> Generator[PandasDataFrame, None, None]:
return self._get_pandas_df_by_chunks(sql, parameters, chunksize=chunksize, **kwargs)
return self.get_df_by_chunks(sql, parameters, chunksize=chunksize, df_type="pandas", **kwargs)

@overload
def get_df(
Expand Down
9 changes: 7 additions & 2 deletions providers/common/sql/tests/unit/common/sql/hooks/test_sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,11 +313,16 @@ def test_uri_with_schema(self):
@pytest.mark.parametrize(
"df_type, expected_type",
[
("test_default_df_type", pd.DataFrame),
("pandas", pd.DataFrame),
("polars", pl.DataFrame),
],
)
def test_get_df_with_df_type(db, df_type, expected_type):
dbapi_hook = mock_db_hook(DbApiHook)
df = dbapi_hook.get_df("SQL", df_type=df_type)
assert isinstance(df, expected_type)
if df_type == "test_default_df_type":
df = dbapi_hook.get_df("SQL")
assert isinstance(df, pd.DataFrame)
else:
df = dbapi_hook.get_df("SQL", df_type=df_type)
assert isinstance(df, expected_type)
Loading