Skip to content

Conversation

@gopidesupavan
Copy link
Member

error: https://github.com/apache/airflow/actions/runs/14542509445/job/40803176027?pr=49447#step:6:3744


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:snowflake Issues related to Snowflake provider labels Apr 18, 2025
@gopidesupavan
Copy link
Member Author

cc: @Sharashchandra

@amoghrajesh amoghrajesh merged commit 78f00a3 into apache:main Apr 19, 2025
65 checks passed
@gopidesupavan
Copy link
Member Author

I just realised, @eladkal this could be a breaking change , the method is public facing interface, WDYT ? should i revert and add mypy ignore check.

Ideally the get_oauth_token is being added in SnowflakeHook, so we dont need this method in SnowflakeSqlApiHook, this can be inherited from SnowflakeHook

@gopidesupavan gopidesupavan deleted the fix-mypy-snowflake-hook branch April 19, 2025 10:04
@bugraoz93
Copy link
Contributor

I just realised, @eladkal this could be a breaking change , the method is public facing interface, WDYT ? should i revert and add mypy ignore check.

Ideally the get_oauth_token is being added in SnowflakeHook, so we dont need this method in SnowflakeSqlApiHook, this can be inherited from SnowflakeHook

I agree that it was recently added to SnowflakeHook. We can deprecate the method first and call from SnowflakeHook to give a deprecation warning for direct usage. Do you think we need to add a news fragment for this?

@amoghrajesh
Copy link
Contributor

@gopidesupavan it shouldnt be a problem and can be included in the next wave?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:snowflake Issues related to Snowflake provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants