Fix SnowflakeSqlApiHook backwards compatibility #49482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:snowflake
bugraoz93
commented
Apr 20, 2025
providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake_sql_api.py
Outdated
Show resolved
Hide resolved
bugraoz93
force-pushed
the
snowflake-backward-compatibility
branch
from
2a35f71 to
d815ad5
Compare
amoghrajesh
reviewed
Apr 21, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Approach looks ok, one case needs handling. Also can you add test to check for region and account?
providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake_sql_api.py
Outdated
Show resolved
Hide resolved
providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake.py
Outdated
Show resolved
Hide resolved
Member
|
BTW thanks for getting this fix. |
bugraoz93
force-pushed
the
snowflake-backward-compatibility
branch
2 times, most recently
from
a4bc510 to
fba4a3d
Compare
Contributor
Author
|
Thanks a lot for the reviews! |
eladkal
reviewed
Apr 22, 2025
providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake_sql_api.py
Outdated
Show resolved
Hide resolved
bugraoz93
force-pushed
the
snowflake-backward-compatibility
branch
from
fba4a3d to
80a33d3
Compare
eladkal
reviewed
Apr 23, 2025
providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake_sql_api.py
Outdated
Show resolved
Hide resolved
potiuk
force-pushed
the
snowflake-backward-compatibility
branch
from
6b76c0a to
40accb8
Compare
potiuk
approved these changes
Apr 23, 2025
…d add test case for connection params for oauth
bugraoz93
force-pushed
the
snowflake-backward-compatibility
branch
from
40accb8 to
315d643
Compare
prabhusneha
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 25, 2025
…ethod (apache#49482) * Fix SnowflakeSqlApiHook backwards compatibility * Update providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake_sql_api.py --------- Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
31 tasks
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow Up: #49449
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.