fix(snowflake_oauth): Fix infinite recursive call of _get_conn_params while getting oauth token from snowflake

[Sharashchandra]

Bug introduced in: #49482
The infinite loop was caused by calling the property self._get_conn_params in the property self.account_identifier. The self.account_identifier was used in the get_oauth_token function, thus resulting in the infinite loop of calls to self._get_conn_params

---

[Sharashchandra]

cc: @eladkal @gopidesupavan @bugraoz93

[bugraoz93]

Thanks @Sharashchandra !

[eladkal]

Tests are failing

FAILED providers/snowflake/tests/unit/snowflake/hooks/test_snowflake_sql_api.py::TestSnowflakeSqlApiHook::test_proper_parametrization_of_execute_query_api_request[test_hook_params0-select i from user_test order by i;-1-expected_payload0-expected_response0] - AttributeError: 'SnowflakeSqlApiHook' object has no attribute 'account_identifier'

[bugraoz93]

Yes, most probably, the property is now a method and needs to be updated in the test accordingly

[Sharashchandra]

Fixed that. Reverting the account_identifier property to remain as it was before because it's used in multiple places in the SnowflakeSqlApiHook
I'm using the account name to construct the url for snowflake oauth.
We don't need the region to be used in the url anymore as that's a legacy valid url
https://docs.snowflake.com/en/user-guide/organizations-connect#label-connecting-via-url

cc: @eladkal @bugraoz93

[eladkal]

Tests are still failing
FAILED providers/snowflake/tests/unit/snowflake/hooks/test_snowflake.py::TestPytestSnowflakeHook::test_get_oauth_token - AssertionError: expected call not found.

[bugraoz93]

Yes, because we remove the region now tests are expecting it

[Sharashchandra]

Fixed the test cases, eveything is passing