Rename operation IDs for task instance endpoints to include map index… #49608
Conversation
… for openapi spec validator
abhishekbhakat
requested review from
bugraoz93,
ephraimbuddy,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
abhishekbhakat
requested review from
bbovenzi,
jscheffl and
ryanahamilton
as code owners
There was a problem hiding this comment.
Thanks for the PR. Looks good to me ( maybe rebase later once the CI is fixed. )
Follow up:
I think we can add pre-commit for preventing duplicate operationId.
Maybe not a new one, adding validate_spec in generate-openapi-spec pre-commit will be enough I think.
|
Can you check that It should render in the "Details" tab when you have a task instance selected. |
bugraoz93
left a comment
bugraoz93
left a comment
There was a problem hiding this comment.
Looks good! As mentioned, revase, fix CI, and manual tests would be awesome. Thanks for the pr!
@bbovenzi this is what I got |
|
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Looks good. Tested locally and working.
I don't think we need unit test for that. I think what Bugra was referring to manual testing. (verifying in the UI that everything looks correct for marking a mapped task and normal task as success or failure, as well as updating the task notes).
Yeah, I wasn't on the computer, checked it now :) Yes, as Pierre mentioned, I meant the manual test |
abhishekbhakat
requested review from
ashb,
gopidesupavan and
potiuk
as code owners
|
Added validation of openapi spec logic in the CC @jason810496 |
apache#49608) * Rename operation IDs for task instance endpoints to include map index for openapi spec validator * refactor: Update TaskInstanceService methods and types to use map index for dependencies * Add OpenAPI validation to FastAPI spec generation script * refactor: streamline OpenAPI validation process by removing redundant exit checks
#49608) * Rename operation IDs for task instance endpoints to include map index for openapi spec validator * refactor: Update TaskInstanceService methods and types to use map index for dependencies * Add OpenAPI validation to FastAPI spec generation script * refactor: streamline OpenAPI validation process by removing redundant exit checks (cherry picked from commit 1cd8614)
#49608) * Rename operation IDs for task instance endpoints to include map index for openapi spec validator * refactor: Update TaskInstanceService methods and types to use map index for dependencies * Add OpenAPI validation to FastAPI spec generation script * refactor: streamline OpenAPI validation process by removing redundant exit checks (cherry picked from commit 1cd8614)
6 participants
closes: #49607