-
Notifications
You must be signed in to change notification settings - Fork 16.5k
Fix docker compose tests #49814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docker compose tests #49814
Conversation
The docker compose tests on linux have been broken by apache#49681 because of: a) perrmission problems with config folder - airflow.cfg created eventually was owned by root, not airflow user and it was not readable by the airflow user b) the airflow.cfg has not been initialized in init because airflow version command does not create config c) config directory has not been crated in the docker-compose test d) /opts/ directory was used to create dirs instead of /opt/ when changing permissions e) chown -R does not work across the volumes Also it turned out that diagnostic in case of health-check problms has been broken and did not show the actual errors - because while handling exception of health check api calls were made that also raised exception that was subsequently silently swallowed and did not allow the logs and heealth-check information from the test to be printed. This PR fixes those problems: a) creates config folder during tests b) runs "airflow config list" in init that actually creates a default config when no manual configuration is specified c) changes ownership for the internal folders after the config file is created which allows airflow user to read it, also spearately changes ownership for /opt/airflow (volume in image) and all the shared volumes mounted from the host. d) improves diagnostic by switching to rich print and handing the health exceptions during exception handling, allowing to print detailed logs of what happened e) the output of `breeze testing docker-compose-tests` is printed directly to stdout (with pytest `-s` flag) - so that we see the progress of test as it happens - both locally and in CI.
|
cc: @dheerajturaga -> there were quite a few issues with the docker-compose on Linux after #49814 - I fixed all of them and improved diagnostics (a lot) for the future. |
|
One of the problems solved is that if the docker-compose was unhealthy, all the logs and service information has not been printed on error and we did not see progress of the tests. With this change - when there is an error - this kind of logs will be printed: You can also test it locally even if everything works with |
amoghrajesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better! These diagnostics will surely help
The docker compose tests on linux have been broken by #49681 because of: a) perrmission problems with config folder - airflow.cfg created eventually was owned by root, not airflow user and it was not readable by the airflow user b) the airflow.cfg has not been initialized in init because airflow version command does not create config c) config directory has not been crated in the docker-compose test d) /opts/ directory was used to create dirs instead of /opt/ when changing permissions e) chown -R does not work across the volumes Also it turned out that diagnostic in case of health-check problms has been broken and did not show the actual errors - because while handling exception of health check api calls were made that also raised exception that was subsequently silently swallowed and did not allow the logs and heealth-check information from the test to be printed. This PR fixes those problems: a) creates config folder during tests b) runs "airflow config list" in init that actually creates a default config when no manual configuration is specified c) changes ownership for the internal folders after the config file is created which allows airflow user to read it, also spearately changes ownership for /opt/airflow (volume in image) and all the shared volumes mounted from the host. d) improves diagnostic by switching to rich print and handing the health exceptions during exception handling, allowing to print detailed logs of what happened e) the output of `breeze testing docker-compose-tests` is printed directly to stdout (with pytest `-s` flag) - so that we see the progress of test as it happens - both locally and in CI. (cherry picked from commit 67ce622) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
|
Nice and clear :) |
The docker compose tests on linux have been broken by #49681 because of: a) perrmission problems with config folder - airflow.cfg created eventually was owned by root, not airflow user and it was not readable by the airflow user b) the airflow.cfg has not been initialized in init because airflow version command does not create config c) config directory has not been crated in the docker-compose test d) /opts/ directory was used to create dirs instead of /opt/ when changing permissions e) chown -R does not work across the volumes Also it turned out that diagnostic in case of health-check problms has been broken and did not show the actual errors - because while handling exception of health check api calls were made that also raised exception that was subsequently silently swallowed and did not allow the logs and heealth-check information from the test to be printed. This PR fixes those problems: a) creates config folder during tests b) runs "airflow config list" in init that actually creates a default config when no manual configuration is specified c) changes ownership for the internal folders after the config file is created which allows airflow user to read it, also spearately changes ownership for /opt/airflow (volume in image) and all the shared volumes mounted from the host. d) improves diagnostic by switching to rich print and handing the health exceptions during exception handling, allowing to print detailed logs of what happened e) the output of `breeze testing docker-compose-tests` is printed directly to stdout (with pytest `-s` flag) - so that we see the progress of test as it happens - both locally and in CI. (cherry picked from commit 67ce622) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
|
Pretty clean! Thank you!! |
Missed in apache#49814 (cherry picked from commit 2eb5928) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
The docker compose tests on linux have been broken by apache#49681 because of: a) perrmission problems with config folder - airflow.cfg created eventually was owned by root, not airflow user and it was not readable by the airflow user b) the airflow.cfg has not been initialized in init because airflow version command does not create config c) config directory has not been crated in the docker-compose test d) /opts/ directory was used to create dirs instead of /opt/ when changing permissions e) chown -R does not work across the volumes Also it turned out that diagnostic in case of health-check problms has been broken and did not show the actual errors - because while handling exception of health check api calls were made that also raised exception that was subsequently silently swallowed and did not allow the logs and heealth-check information from the test to be printed. This PR fixes those problems: a) creates config folder during tests b) runs "airflow config list" in init that actually creates a default config when no manual configuration is specified c) changes ownership for the internal folders after the config file is created which allows airflow user to read it, also spearately changes ownership for /opt/airflow (volume in image) and all the shared volumes mounted from the host. d) improves diagnostic by switching to rich print and handing the health exceptions during exception handling, allowing to print detailed logs of what happened e) the output of `breeze testing docker-compose-tests` is printed directly to stdout (with pytest `-s` flag) - so that we see the progress of test as it happens - both locally and in CI.

The docker compose tests on linux have been broken by #49681 because of:
a) perrmission problems with config folder - airflow.cfg created
eventually was owned by root, not airflow user and it was not
readable by the airflow user
b) the airflow.cfg has not been initialized in init because airflow
version command does not create config
c) config directory has not been crated in the docker-compose test d) /opts/ directory was used to create dirs instead of /opt/ when
changing permissions
e) chown -R does not work across the volumes
Also it turned out that diagnostic in case of health-check problms has been broken and did not show the actual errors - because while handling exception of health check api calls were made that also raised exception that was subsequently silently swallowed and did not allow the logs and heealth-check information from the test to be printed.
This PR fixes those problems:
a) creates config folder during tests
b) runs "airflow config list" in init that actually creates a
default config when no manual configuration is specified
c) changes ownership for the internal folders after the config
file is created which allows airflow user to read it, also
spearately changes ownership for /opt/airflow (volume in image)
and all the shared volumes mounted from the host.
d) improves diagnostic by switching to rich print and handing the
health exceptions during exception handling, allowing to print
detailed logs of what happened
e) the output of
breeze testing docker-compose-testsis printeddirectly to stdout (with pytest
-sflag) - so that we seethe progress of test as it happens - both locally and in CI.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.