Skip to content

Conversation

@github-actions
Copy link

The docker compose tests on linux have been broken by #49681 because
of:

a) perrmission problems with config folder - airflow.cfg created
eventually was owned by root, not airflow user and it was not
readable by the airflow user
b) the airflow.cfg has not been initialized in init because airflow
version command does not create config
c) config directory has not been crated in the docker-compose test
d) /opts/ directory was used to create dirs instead of /opt/ when
changing permissions
e) chown -R does not work across the volumes

Also it turned out that diagnostic in case of health-check problms
has been broken and did not show the actual errors - because
while handling exception of health check api calls were made that
also raised exception that was subsequently silently swallowed and
did not allow the logs and heealth-check information from the test
to be printed.

This PR fixes those problems:

a) creates config folder during tests
b) runs "airflow config list" in init that actually creates a
default config when no manual configuration is specified
c) changes ownership for the internal folders after the config
file is created which allows airflow user to read it, also
spearately changes ownership for /opt/airflow (volume in image)
and all the shared volumes mounted from the host.
d) improves diagnostic by switching to rich print and handing the
health exceptions during exception handling, allowing to print
detailed logs of what happened
e) the output of breeze testing docker-compose-tests is printed
directly to stdout (with pytest -s flag) - so that we see
the progress of test as it happens - both locally and in CI.
(cherry picked from commit 67ce622)

Co-authored-by: Jarek Potiuk jarek@potiuk.com

The docker compose tests on linux have been broken by #49681 because
of:

a) perrmission problems with config folder - airflow.cfg created
   eventually was owned by root, not airflow user and it was not
   readable by the airflow user
b) the airflow.cfg has not been initialized in init because airflow
   version command does not create config
c) config directory has not been crated in the docker-compose test
d) /opts/ directory was used to create dirs instead of /opt/ when
   changing permissions
e) chown -R does not work across the volumes

Also it turned out that diagnostic in case of health-check problms
has been broken and did not show the actual errors - because
while handling exception of health check api calls were made that
also raised exception that was subsequently silently swallowed and
did not allow the logs and heealth-check information from the test
to be printed.

This PR fixes those problems:

a) creates config folder during tests
b) runs "airflow config list" in init that actually creates a
   default config when no manual configuration is specified
c) changes ownership for the internal folders after the config
   file is created which allows airflow user to read it, also
   spearately changes ownership for /opt/airflow (volume in image)
   and all the shared volumes mounted from the host.
d) improves diagnostic by switching to rich print and handing the
   health exceptions during exception handling, allowing to print
   detailed logs of what happened
e) the output of `breeze testing docker-compose-tests` is printed
   directly to stdout (with pytest `-s` flag) - so that we see
   the progress of test as it happens - both locally and in CI.
(cherry picked from commit 67ce622)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
@boring-cyborg boring-cyborg bot added area:production-image Production image improvements and fixes kind:documentation labels Apr 26, 2025
@potiuk potiuk marked this pull request as ready for review April 26, 2025 11:33
@potiuk potiuk merged commit 884b335 into v3-0-test Apr 26, 2025
71 checks passed
@potiuk potiuk deleted the backport-67ce622-v3-0-test branch April 26, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant