[v3-0-test] Fix docker compose tests (#49814) #49817
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker compose tests on linux have been broken by #49681 because
of:
a) perrmission problems with config folder - airflow.cfg created
eventually was owned by root, not airflow user and it was not
readable by the airflow user
b) the airflow.cfg has not been initialized in init because airflow
version command does not create config
c) config directory has not been crated in the docker-compose test
d) /opts/ directory was used to create dirs instead of /opt/ when
changing permissions
e) chown -R does not work across the volumes
Also it turned out that diagnostic in case of health-check problms
has been broken and did not show the actual errors - because
while handling exception of health check api calls were made that
also raised exception that was subsequently silently swallowed and
did not allow the logs and heealth-check information from the test
to be printed.
This PR fixes those problems:
a) creates config folder during tests
b) runs "airflow config list" in init that actually creates a
default config when no manual configuration is specified
c) changes ownership for the internal folders after the config
file is created which allows airflow user to read it, also
spearately changes ownership for /opt/airflow (volume in image)
and all the shared volumes mounted from the host.
d) improves diagnostic by switching to rich print and handing the
health exceptions during exception handling, allowing to print
detailed logs of what happened
e) the output of
breeze testing docker-compose-testsis printeddirectly to stdout (with pytest
-sflag) - so that we seethe progress of test as it happens - both locally and in CI.
(cherry picked from commit 67ce622)
Co-authored-by: Jarek Potiuk jarek@potiuk.com