-
Notifications
You must be signed in to change notification settings - Fork 16.3k
[AIP-86] Add deadline to DAG model #50093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ferruzzi
merged 9 commits into
apache:main
from
aws-mwaa:ferruzzi/deadlines/add-deadline-to-dag-model
May 15, 2025
Merged
[AIP-86] Add deadline to DAG model #50093
ferruzzi
merged 9 commits into
apache:main
from
aws-mwaa:ferruzzi/deadlines/add-deadline-to-dag-model
May 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Looks like I need to add a db migration for the DateTime => DateTimeUTC type change. Fix coming. |
vincbeck
reviewed
May 1, 2025
o-nikolas
reviewed
May 1, 2025
airflow-core/src/airflow/migrations/versions/0070_3_1_0_change_deadline_to_utc.py
Outdated
Show resolved
Hide resolved
o-nikolas
approved these changes
May 6, 2025
18e226d to
b3e2426
Compare
1 task
vincbeck
approved these changes
May 13, 2025
ramitkataria
approved these changes
May 14, 2025
1fanwang
approved these changes
May 14, 2025
Contributor
1fanwang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, LGTM, left minor comments mostly for my learning.
Example usage: ``` @task def hello(): log.info('hello world') with DAG( dag_id='dag_with_deadline', deadline=DeadlineAlert( trigger=DeadlineTrigger.DAGRUN_LOGICAL_DATE, interval=timedelta(hours=1), callback=hello_callback, ) ): hello() ```
…re a calculated datetime/timestamp, from DateTime to DateTimeUTC.
1 task
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
* Add deadline to DAG model Example usage: ``` @task def hello(): log.info('hello world') with DAG( dag_id='dag_with_deadline', deadline=DeadlineAlert( trigger=DeadlineTrigger.DAGRUN_LOGICAL_DATE, interval=timedelta(hours=1), callback=hello_callback, ) ): hello() ```
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Sep 26, 2025
This was removed in apache#50093 -- I assume by mistake! Adding this back to not break das of people migration from Airflow 2.x
amoghrajesh
pushed a commit
that referenced
this pull request
Sep 26, 2025
This was removed in #50093 -- I assume by mistake! Adding this back to not break das of people migration from Airflow 2.x
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Sep 30, 2025
This was removed in apache#50093 -- I assume by mistake! Adding this back to not break das of people migration from Airflow 2.x
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
This was removed in apache#50093 -- I assume by mistake! Adding this back to not break das of people migration from Airflow 2.x
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
This was removed in apache#50093 -- I assume by mistake! Adding this back to not break das of people migration from Airflow 2.x
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
This was removed in apache#50093 -- I assume by mistake! Adding this back to not break das of people migration from Airflow 2.x
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
This was removed in apache#50093 -- I assume by mistake! Adding this back to not break das of people migration from Airflow 2.x
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
This was removed in apache#50093 -- I assume by mistake! Adding this back to not break das of people migration from Airflow 2.x
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
This was removed in apache#50093 -- I assume by mistake! Adding this back to not break das of people migration from Airflow 2.x
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
This was removed in apache#50093 -- I assume by mistake! Adding this back to not break das of people migration from Airflow 2.x
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
This was removed in apache#50093 -- I assume by mistake! Adding this back to not break das of people migration from Airflow 2.x
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
This was removed in apache#50093 -- I assume by mistake! Adding this back to not break das of people migration from Airflow 2.x
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
This was removed in apache#50093 -- I assume by mistake! Adding this back to not break das of people migration from Airflow 2.x
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
This was removed in apache#50093 -- I assume by mistake! Adding this back to not break das of people migration from Airflow 2.x
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
This was removed in apache#50093 -- I assume by mistake! Adding this back to not break das of people migration from Airflow 2.x
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Oct 12, 2025
This was removed in apache#50093 -- I assume by mistake! Adding this back to not break das of people migration from Airflow 2.x
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
This was removed in apache#50093 -- I assume by mistake! Adding this back to not break das of people migration from Airflow 2.x
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
This was removed in apache#50093 -- I assume by mistake! Adding this back to not break das of people migration from Airflow 2.x
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
This was removed in apache#50093 -- I assume by mistake! Adding this back to not break das of people migration from Airflow 2.x
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
This was removed in apache#50093 -- I assume by mistake! Adding this back to not break das of people migration from Airflow 2.x
kaxil
added a commit
that referenced
this pull request
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:DAG-processing
area:db-migrations
PRs with DB migration
area:serialization
area:task-sdk
kind:documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step in AIP-86 to add Deadline Alerts. Plenty more to come, but I wanted to break it down into reasonable bites for easier review.
This PR adds the new Deadline field to the DAG database table, a new model to handle the Deadline, and the unit tests to cover those additions. The next PR (already queued up once this is merged) will implement the DeadlineTrigger class which I sketched out in this one.
Example usage:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.