Skip to content

Conversation

@amoghrajesh
Copy link
Contributor

closes: #54386

There were couple of occurrences of airflow.utils.module_loading in task sdk:

  1. import_string: used in definitions & io, cannot eliminate airflow.utils.module_loading.import_string as its used across the codebase, so, moved them to a new module: airflow.sdk.module_loading
  2. qualname: similar to above, used widely
  3. is_valid_dotpath: was added recently for deadlines, moved to inside Callback class in deadlines.

Compat:

No need for compat because:

  1. import_string and qualname cannot be removed due to wide usage
  2. is_valid_dotpath => moved inside Callback class but it was added to utils in [AIP-86] Add deadline to DAG model #50093 which has not yet been released (3.1 target), so its safe to move it

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@amoghrajesh amoghrajesh requested a review from kaxil August 14, 2025 09:10
@amoghrajesh
Copy link
Contributor Author

@kaxil @ferruzzi I moved it to module_loading under sdk. WDYT?

Copy link
Contributor

@ferruzzi ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Approved pending green CI

@potiuk
Copy link
Member

potiuk commented Aug 15, 2025

Errors though :(

@amoghrajesh
Copy link
Contributor Author

Strange, I think those arent related, let me re run.

@potiuk
Copy link
Member

potiuk commented Aug 18, 2025

I think you need to rebase. the thing is that if you re-run old run the artifact might be already gone.

@amoghrajesh
Copy link
Contributor Author

Yeah I was rebasing it :)

@amoghrajesh
Copy link
Contributor Author

Alright green finally.

@amoghrajesh amoghrajesh merged commit 871dc8a into apache:main Aug 18, 2025
105 checks passed
@amoghrajesh amoghrajesh deleted the remove-utils-module-loading-refs branch August 18, 2025 14:20
mangal-vairalkar pushed a commit to mangal-vairalkar/airflow that referenced this pull request Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Remove references of airflow.utils.module_loading in task SDK

4 participants