-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Remove references of airflow.utils.module_loading in task SDK
#54388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
amoghrajesh
merged 6 commits into
apache:main
from
astronomer:remove-utils-module-loading-refs
Aug 18, 2025
Merged
Remove references of airflow.utils.module_loading in task SDK
#54388
amoghrajesh
merged 6 commits into
apache:main
from
astronomer:remove-utils-module-loading-refs
Aug 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
reviewed
Aug 12, 2025
Contributor
Author
kaxil
approved these changes
Aug 14, 2025
ferruzzi
approved these changes
Aug 14, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Approved pending green CI
Member
|
Errors though :( |
Contributor
Author
|
Strange, I think those arent related, let me re run. |
Member
|
I think you need to rebase. the thing is that if you re-run old run the artifact might be already gone. |
Contributor
Author
|
Yeah I was rebasing it :) |
Contributor
Author
|
Alright green finally. |
mangal-vairalkar
pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #54386
There were couple of occurrences of
airflow.utils.module_loadingin task sdk:airflow.utils.module_loading.import_stringas its used across the codebase, so, moved them to a new module:airflow.sdk.module_loadingCompat:
No need for compat because:
Callbackclass but it was added to utils in [AIP-86] Add deadline to DAG model #50093 which has not yet been released (3.1 target), so its safe to move it^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.