Skip to content

Conversation

@guan404ming
Copy link
Member

@guan404ming guan404ming commented May 6, 2025

Why

The PEP is no longer normative. The current spec is https://typing.readthedocs.io/en/latest/spec/overload.html and it says pretty clearly that the implementation is required only in .py files.

How

  • remove the overload in .pyi and add them in .py

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@guan404ming guan404ming changed the title Update type to follow newest PEP Update type to follow newest typing spec May 6, 2025
@guan404ming guan404ming marked this pull request as ready for review May 6, 2025 09:57
@guan404ming guan404ming requested a review from eladkal as a code owner May 6, 2025 09:57
@guan404ming
Copy link
Member Author

guan404ming commented May 6, 2025

@eladkal Not sure whether it's still possible to also add this pr in 1.27.0 or we have to add it in 1.28.0. If could add it in 1.27.0, that would be great since we could test it in our amazon and slack migration.

@potiuk
Copy link
Member

potiuk commented May 6, 2025

@eladkal Not sure whether it's still possible to also add this pr in 1.27.0 or we have to add it in 1.28.0. If could add it in 1.27.0, that would be great since we could test it in our amazon and slack migration.

I guess it is not breaking anything so we can easily defer it to 1.28.0

@potiuk potiuk merged commit 6204dba into apache:main May 6, 2025
129 checks passed
@guan404ming guan404ming deleted the update-type-def branch May 11, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants