-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Migrate HiveToDynamoDBOperator and SqlToS3Operator to use get_df
#50126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
86d526e to
8a30a7f
Compare
51667c8 to
bc63964
Compare
bc63964 to
98da798
Compare
providers/amazon/src/airflow/providers/amazon/aws/transfers/hive_to_dynamodb.py
Outdated
Show resolved
Hide resolved
98da798 to
49c53c5
Compare
|
Failed since the |
|
Here is the PR #50211 |
|
Hi, I’ve tried to figure out why Thanks in advance! |
|
When I keep searching the answer I find the type def did not really following the newest python typing spec, thus I update them in #50229. I think maybe it could solve the error here since it didn't rely on the |
49c53c5 to
814d079
Compare
|
Mypy seems passed and even the |
814d079 to
8ed059e
Compare
|
Pushed again to ensure it is stable. |
8ed059e to
47bb0cf
Compare
|
Mypy works great and push again for unrelated ci error |
Co-authored-by: Jarek Potiuk <potiuk@apache.org>
47bb0cf to
c40b4be
Compare
Amazon/transfer to use get_dfHiveToDynamoDBOperator and SqlToS3Operator to use get_df
|
Thanks for the suggestions and review! |
apache#50126) Co-authored-by: Jarek Potiuk <potiuk@apache.org>


Related Issue
get_pandas_dftoget_dfinproviders#49334cc: @potiuk @eladkal
Why
get_pandas_dfdeprecated in #48875, which would be replaced byget_df. Thus, we need to migrate them in providers.How
Amazon/transferNote
There is some workaround for type here. It should be removed after the common-sql bundle the refined type definition. I've added the TODO in the comment and would get back here after the release.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.