UI: Implement navigation on bar click #50416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyLee1224
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
guan404ming
reviewed
May 10, 2025
Member
guan404ming
left a comment
guan404ming
left a comment
There was a problem hiding this comment.
Overall looks good! Two comments.
RoyLee1224
force-pushed
the
feature/click-to-navigate-50184
branch
from
66fbc26 to
28102a7
Compare
Contributor
Author
|
Implemented click-to-navigate for task instances as well. TI_click-to-navigate.mp4 |
RoyLee1224
force-pushed
the
feature/click-to-navigate-50184
branch
from
9f65ec1 to
21f0a79
Compare
Contributor
Author
|
Thanks for the detailed feedback! |
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
* UI: implement navigation on bar click * use default tooltip * fix: remove unnecessary type assertion and add TI overview click-to-navigate function * refactor: optimize hover handling in DurationChart * nit:Use switch statement and extract common path (cherry picked from commit 21ca3ce)
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
* UI: implement navigation on bar click * use default tooltip * fix: remove unnecessary type assertion and add TI overview click-to-navigate function * refactor: optimize hover handling in DurationChart * nit:Use switch statement and extract common path (cherry picked from commit 21ca3ce)
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
* UI: implement navigation on bar click * use default tooltip * fix: remove unnecessary type assertion and add TI overview click-to-navigate function * refactor: optimize hover handling in DurationChart * nit:Use switch statement and extract common path
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#50184
cc: @bbovenzi
Why
Issue #50184 highlights the need for click-to-navigate functionality for managing and debugging DAG runs, with a particular focus on long-running instances.
How
onClickfor navigation to Dag run detailsonHoverfor hover effectclick-to-navigate.mp4
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.