Skip to content

UI: Implement navigation on bar click #50416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbovenzi merged 5 commits into from
May 12, 2025
Merged

UI: Implement navigation on bar click #50416

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
830f07b
UI: implement navigation on bar click
RoyLee1224 May 9, 2025
8461395
use default tooltip
RoyLee1224 May 9, 2025
933ad81
fix: remove unnecessary type assertion and add TI overview click-to-n…
RoyLee1224 May 10, 2025
2353d21
refactor: optimize hover handling in DurationChart
RoyLee1224 May 10, 2025
21f0a79
nit:Use switch statement and extract common path
RoyLee1224 May 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion airflow-core/src/airflow/ui/src/components/DurationChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import type { PartialEventContext } from "chartjs-plugin-annotation";
import annotationPlugin from "chartjs-plugin-annotation";
import dayjs from "dayjs";
import { Bar } from "react-chartjs-2";
import { useNavigate } from "react-router-dom";

import type { TaskInstanceResponse, DAGRunResponse } from "openapi/requests/types.gen";
import { system } from "src/theme";
Expand Down Expand Up @@ -64,6 +65,8 @@ export const DurationChart = ({
readonly entries: Array<RunResponse> | undefined;
readonly kind: "Dag Run" | "Task Instance";
}) => {
const navigate = useNavigate();

if (!entries) {
return undefined;
}
Expand Down Expand Up @@ -141,6 +144,33 @@ export const DurationChart = ({
}}
datasetIdKey="id"
options={{
onClick: (_event, elements) => {
const [element] = elements;

if (!element) {
return;
}

const entry = entries[element.index];
const baseUrl = `/dags/${entry?.dag_id}/runs/${entry?.dag_run_id}`;

switch (kind) {
case "Dag Run": {
navigate(baseUrl);
break;
}
case "Task Instance": {
const taskInstance = entry as TaskInstanceResponse;

navigate(`${baseUrl}/tasks/${taskInstance.task_id}`);
break;
}
default:
}
},
onHover: (_event, elements, chart) => {
chart.canvas.style.cursor = elements.length > 0 ? "pointer" : "default";
},
plugins: {
annotation: {
annotations: {
Expand All @@ -158,7 +188,6 @@ export const DurationChart = ({
},
title: { align: "end", display: true, text: "Run After" },
},

y: {
title: { align: "end", display: true, text: "Duration (seconds)" },
},
Expand Down