-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Flattening the requirements input for python venv operators
#50521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
requirements input for python venv operators
|
tests failure not related. merging |
|
Teat failures already fixed on main |
|
Nice! |
| else: | ||
| for raw_str in self.requirements: | ||
| requirements_iterable = [] | ||
| if isinstance(self.requirements, str): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I missed the fact that requirements could be other thing than a list. But based on the constructor code, it looks impossible to get a string here:
elif isinstance(requirements, str):
self.requirements = [requirements]There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call.
Follow-up to apache#50446 and apache#50521: - Clean up requirements-flattening logic. - Add tests for requirements passed as multi-line strings.
Follow-up to apache#50446 and apache#50521: - Clean up requirements-flattening logic. - Add tests for requirements passed as multi-line strings.
Follow-up to apache#50446 and apache#50521: - Clean up requirements-flattening logic. - Add tests for requirements passed as multi-line strings.
Follow-up to apache#50446 and apache#50521: - Clean up requirements-flattening logic. - Add tests for requirements passed as multi-line strings.
Follow-up to apache#50446 and apache#50521: - Clean up requirements-flattening logic. - Add tests for requirements passed as multi-line strings.
…#50521) * Flattening the requirements for python virtual env operator * Refine BigQuery test with field-wise comparison of access_entries
Follow-up to apache#50446 and apache#50521: - Clean up requirements-flattening logic. - Add tests for requirements passed as multi-line strings.
#50446 did some rework on the way requirements are parsed. This was leading to some of the traditional ways of passing requirements to the venv operators to break.
Tested with:
All good now.
Example failures: https://github.com/apache/airflow/actions/runs/14986598214
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.