-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Improve testing for context serialization #50566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
shahar1
merged 1 commit into
apache:main
from
yannlambret:improve-testing-for-context-serialization
May 18, 2025
Merged
Improve testing for context serialization #50566
shahar1
merged 1 commit into
apache:main
from
yannlambret:improve-testing-for-context-serialization
May 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
No problem! Thanks for taking this on. |
amoghrajesh
approved these changes
May 14, 2025
Contributor
amoghrajesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
amoghrajesh
reviewed
May 14, 2025
providers/standard/tests/unit/standard/operators/test_python.py
Outdated
Show resolved
Hide resolved
f2d7bc9 to
f07de43
Compare
Contributor
|
Test failures are unrelated: rebasing it |
Follow-up to apache#50446 and apache#50521: - Clean up requirements-flattening logic. - Add tests for requirements passed as multi-line strings.
aeafb68 to
8f6214d
Compare
Contributor
Author
|
Hi @amoghrajesh, I've rebased my branch cleanly onto |
Contributor
Author
|
All good! |
Contributor
Author
|
Hello @eladkal, could you please review this? |
shahar1
approved these changes
May 18, 2025
dadonnelly316
pushed a commit
to dadonnelly316/airflow
that referenced
this pull request
May 26, 2025
Follow-up to apache#50446 and apache#50521: - Clean up requirements-flattening logic. - Add tests for requirements passed as multi-line strings.
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
Follow-up to apache#50446 and apache#50521: - Clean up requirements-flattening logic. - Add tests for requirements passed as multi-line strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #50446 and #50521:
Following @shahar1 PR (#50521), I cleaned up a little bit the flattening logic of
_iter_serializable_context_keys, in connection with this part of the__init__functionof
PythonVirtualenvOperatorclass:As
self.requirementsis always a list starting from there, it simplifies the way we can process it later. I also add the use cases detailed in #50521 to the relevant test. Sorry for my initial over-simplification 🙏🏻