Always use shared cache, no matter if we are using uv or not #50923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
amoghrajesh,
ashb,
gopidesupavan and
jedcunningham
as code owners
amoghrajesh
approved these changes
May 21, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Oh! Lets see how it goes
eladkal
approved these changes
May 21, 2025
sunank200
approved these changes
May 21, 2025
potiuk
force-pushed
the
always-use-shared-cache
branch
2 times, most recently
from
14beca8 to
054439b
Compare
Member
Author
|
I had to workaround race when running |
aritra24
approved these changes
May 22, 2025
Another attempt to fix pyspark issues. It turns out that we are not passing the `use_uv` flag in tests, so the cache has not been actually shared between paralllel containers - we change it in the way that the uv cache is shared regardless if use-uv is passed
potiuk
force-pushed
the
always-use-shared-cache
branch
from
054439b to
c8f31b2
Compare
Member
Author
|
Rebased to try it once more |
Collaborator
|
Looks like a static check failure happened now? |
Member
Author
Looks like issue in main |
Member
Author
Fixed in #50935 |
dadonnelly316
pushed a commit
to dadonnelly316/airflow
that referenced
this pull request
May 26, 2025
…50923) Another attempt to fix pyspark issues. It turns out that we are not passing the `use_uv` flag in tests, so the cache has not been actually shared between paralllel containers - we change it in the way that the uv cache is shared regardless if use-uv is passed
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
…50923) Another attempt to fix pyspark issues. It turns out that we are not passing the `use_uv` flag in tests, so the cache has not been actually shared between paralllel containers - we change it in the way that the uv cache is shared regardless if use-uv is passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt to fix pyspark issues. It turns out that we are not passing the
use_uvflag in tests, so the cache has not been actually shared between paralllel containers - we change it in the way that the uv cache is shared regardless if use-uv is passed^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.