Skip to content

Conversation

@Lee-W
Copy link
Member

@Lee-W Lee-W commented May 22, 2025

Why

The checking script was wrong and will be fixed in #50934, but it failed to catch this error back then.

Why

Fix the default value of PubSubPullOperator.deferrable


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels May 22, 2025
@Lee-W Lee-W changed the title Update the default value of PubSubPullOperator.deferrable to conf.getboolean("operators", "default_deferrable", fallback=False) Update the default value of PubSubPullOperator.deferrable to conf.getboolean("operators", "default_deferrable", fallback=False) May 22, 2025
….deferrable to conf.getboolean("operators", "default_deferrable", fallback=False)
@Lee-W Lee-W force-pushed the fix-deferrable-default-value branch from 4d8f684 to 1b4395f Compare May 22, 2025 03:32
@Lee-W Lee-W requested review from amoghrajesh and jason810496 May 22, 2025 09:49
@potiuk potiuk merged commit baef759 into apache:main May 22, 2025
69 checks passed
dadonnelly316 pushed a commit to dadonnelly316/airflow that referenced this pull request May 26, 2025
….deferrable to conf.getboolean("operators", "default_deferrable", fallback=False) (apache#50935)
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
….deferrable to conf.getboolean("operators", "default_deferrable", fallback=False) (apache#50935)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants