Fix default deferrable checking script #50934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
area:providers
provider:google
Lee-W
changed the title
Member
Author
|
After a second thought, let me split this one to 2 PRs |
Lee-W
force-pushed
the
fix-default-deferrable-checking-script
branch
from
209e844 to
b13fb76
Compare
Lee-W
changed the title
rawwar
approved these changes
May 22, 2025
uranusjr
approved these changes
May 22, 2025
jason810496
reviewed
May 22, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Nice catch, thanks, only a small nit for regex matching.
jason810496
approved these changes
May 22, 2025
dadonnelly316
pushed a commit
to dadonnelly316/airflow
that referenced
this pull request
May 26, 2025
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The checking path of
scripts/ci/pre_commit/check_deferrable_default.pywas not updated back to the time we reorganized the project structure.What
scripts/ci/pre_commit/check_deferrable_default.py^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.