Revert #50175 -- resolve 404 log error for non-latest task tries #51135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-host worker environments (apache#50175)" This reverts commit 0b0ff5d.
dstandish
requested review from
bugraoz93,
ephraimbuddy,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
dstandish
added
the
backport-to-v3-1-test
hussein-awala
approved these changes
May 27, 2025
Contributor
Author
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker fbc7156 v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
Member
|
That's weird because at first I though we were only doing reads. But actually I see that in the function later on there is Good catch. |
Member
|
Reverting backport PR: |
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
…-host worker environments (apache#50175)" (apache#51135) This reverts commit 0b0ff5d.
jose-lehmkuhl
pushed a commit
to jose-lehmkuhl/airflow
that referenced
this pull request
Jul 11, 2025
…-host worker environments (apache#50175)" (apache#51135) This reverts commit 0b0ff5d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0b0ff5d from PR #50175.
After that PR, if you clear a TI in UI, then you see two log entries with try number 1, and both the TI record and the TI history record have try number = 1.
It's not clear why.
cc @pierrejeambrun this is a weird one and you may have some ideas.
Screenshot:
Note it's not only a UI / cosmetic issue. The actual row in TI has the wrong try number (1) when it should be 2 after clearing.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.