Skip to content

Conversation

@yaming-github
Copy link
Contributor

@yaming-github yaming-github commented Aug 4, 2025

Closes: #53400
related pr: #51592, #51135

We supported TaskInstanceHistory in log handlers in previous pr but didn't consider the handling inside _read_from_logs_server. There was a change on ti check before but that commit got reverted so this pr should fix the AttributeError.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Aug 4, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@eladkal eladkal added this to the Airflow 3.0.5 milestone Aug 5, 2025
@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Aug 5, 2025
@potiuk potiuk merged commit 3df18a0 into apache:main Aug 6, 2025
104 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 6, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

ferruzzi pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 7, 2025
amoghrajesh pushed a commit to astronomer/airflow that referenced this pull request Aug 11, 2025
amoghrajesh pushed a commit to astronomer/airflow that referenced this pull request Aug 11, 2025
amoghrajesh pushed a commit to astronomer/airflow that referenced this pull request Aug 11, 2025
amoghrajesh pushed a commit to astronomer/airflow that referenced this pull request Aug 11, 2025
kaxil pushed a commit that referenced this pull request Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:logging type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to fetch log for previous task tries in web UI

5 participants