Move example_dags in standard provider to example_dags in sources #51260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
added
the
backport-to-v3-1-test
potiuk
force-pushed
the
move-example-dags-in-standard-to-example-dags
branch
from
0d7d1fc to
4a85b1a
Compare
Member
Author
|
@jedcunningham -> you were totally right - those example dags in provider should be placed elsewhere. We have not yet defined where they will be, but placing them in system_tests was quite wrong. This should fix it - also example_dags for standard provider will also be included in standard provider distribution. cc: @jscheffl |
potiuk
force-pushed
the
move-example-dags-in-standard-to-example-dags
branch
from
4a85b1a to
5133069
Compare
gopidesupavan
approved these changes
May 31, 2025
Member
|
old docs fixes required? |
Member
Author
Separately, yes, some links are broken I found out. |
Folow up after apache#51192. Actually choosing the same approach as for system tests was pretty wrong and even before attempting to have final solution for example_dags/system tests we should move the standard examples out of "tests.system" as rightfully pointed out by Jed in the apache#51192. The snippets of code to run the tests as pytests are not neeeded and they are actually even harmful as they cause import errors when no tests_common is around
potiuk
force-pushed
the
move-example-dags-in-standard-to-example-dags
branch
from
5133069 to
2015a69
Compare
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker cc29e02 v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 1, 2025
… sources (apache#51260) Folow up after apache#51192. Actually choosing the same approach as for system tests was pretty wrong and even before attempting to have final solution for example_dags/system tests we should move the standard examples out of "tests.system" as rightfully pointed out by Jed in the apache#51192. The snippets of code to run the tests as pytests are not neeeded and they are actually even harmful as they cause import errors when no tests_common is around (cherry picked from commit cc29e02) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
that referenced
this pull request
Jun 1, 2025
… sources (#51260) (#51275) Folow up after #51192. Actually choosing the same approach as for system tests was pretty wrong and even before attempting to have final solution for example_dags/system tests we should move the standard examples out of "tests.system" as rightfully pointed out by Jed in the #51192. The snippets of code to run the tests as pytests are not neeeded and they are actually even harmful as they cause import errors when no tests_common is around (cherry picked from commit cc29e02)
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
… sources (#51260) (#51275) Folow up after #51192. Actually choosing the same approach as for system tests was pretty wrong and even before attempting to have final solution for example_dags/system tests we should move the standard examples out of "tests.system" as rightfully pointed out by Jed in the #51192. The snippets of code to run the tests as pytests are not neeeded and they are actually even harmful as they cause import errors when no tests_common is around (cherry picked from commit cc29e02)
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
…ache#51260) Folow up after apache#51192. Actually choosing the same approach as for system tests was pretty wrong and even before attempting to have final solution for example_dags/system tests we should move the standard examples out of "tests.system" as rightfully pointed out by Jed in the apache#51192. The snippets of code to run the tests as pytests are not neeeded and they are actually even harmful as they cause import errors when no tests_common is around
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Folow up after #51192.
Actually choosing the same approach as for system tests was
pretty wrong and even before attempting to have final solution
for example_dags/system tests we should move the standard examples
out of "tests.system" as rightfully pointed out by Jed in
the #51192.
The snippets of code to run the tests as pytests are not neeeded
and they are actually even harmful as they cause import errors
when no tests_common is around.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.