Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jun 1, 2025

… sources (#51260)

Folow up after #51192.

Actually choosing the same approach as for system tests was pretty wrong and even before attempting to have final solution for example_dags/system tests we should move the standard examples out of "tests.system" as rightfully pointed out by Jed in the #51192.

The snippets of code to run the tests as pytests are not neeeded and they are actually even harmful as they cause import errors when no tests_common is around
(cherry picked from commit cc29e02)


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

… sources (apache#51260)

Folow up after apache#51192.

Actually choosing the same approach as for system tests was
pretty wrong and even before attempting to have final solution
for example_dags/system tests we should move the standard examples
out of "tests.system" as rightfully pointed out by Jed in
the apache#51192.

The snippets of code to run the tests as pytests are not neeeded
and they are actually even harmful as they cause import errors
when no tests_common is around
(cherry picked from commit cc29e02)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
@potiuk potiuk requested a review from jscheffl as a code owner June 1, 2025 14:59
@potiuk potiuk merged commit 41f152b into apache:v3-0-test Jun 1, 2025
78 checks passed
@potiuk potiuk deleted the backport-cc29e02-v3-0-test branch June 1, 2025 16:49
kaxil pushed a commit that referenced this pull request Jun 3, 2025
… sources (#51260) (#51275)

Folow up after #51192.

Actually choosing the same approach as for system tests was
pretty wrong and even before attempting to have final solution
for example_dags/system tests we should move the standard examples
out of "tests.system" as rightfully pointed out by Jed in
the #51192.

The snippets of code to run the tests as pytests are not neeeded
and they are actually even harmful as they cause import errors
when no tests_common is around
(cherry picked from commit cc29e02)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants