Fix building PROD images with uv #51277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
area:production-image
potiuk
force-pushed
the
fix-building-prod-images-with-uv
branch
from
7ef91ca to
9edaac6
Compare
potiuk
added
the
canary
When we are building PROD image we use `pip` rather than `uv`, however we should be able to use `uv` to do it. Recently we had a bug that broke it - by using `--group dev` unconditionally - even if we used airflow packages to build airflow. So far we always run the PROD build with `pip` that's why it worked fine, but once fix building with both uv and pip we can build the images with uv by default and run a pip build separately in extra checks. Fixes: apache#50134
potiuk
force-pushed
the
fix-building-prod-images-with-uv
branch
from
9edaac6 to
9bb5664
Compare
2 tasks
potiuk
added
the
backport-to-v3-1-test
gopidesupavan
approved these changes
Jun 2, 2025
aritra24
approved these changes
Jun 2, 2025
eladkal
approved these changes
Jun 2, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jun 2, 2025
When we are building PROD image we use `pip` rather than `uv`, however we should be able to use `uv` to do it. Recently we had a bug that broke it - by using `--group dev` unconditionally - even if we used airflow packages to build airflow. So far we always run the PROD build with `pip` that's why it worked fine, but once fix building with both uv and pip we can build the images with uv by default and run a pip build separately in extra checks. (cherry picked from commit 92a4d60) Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Fixes: #50134
Backport successfully created: v3-0-test
|
potiuk
added a commit
that referenced
this pull request
Jun 2, 2025
When we are building PROD image we use `pip` rather than `uv`, however we should be able to use `uv` to do it. Recently we had a bug that broke it - by using `--group dev` unconditionally - even if we used airflow packages to build airflow. So far we always run the PROD build with `pip` that's why it worked fine, but once fix building with both uv and pip we can build the images with uv by default and run a pip build separately in extra checks. (cherry picked from commit 92a4d60) Fixes: #50134 Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
When we are building PROD image we use `pip` rather than `uv`, however we should be able to use `uv` to do it. Recently we had a bug that broke it - by using `--group dev` unconditionally - even if we used airflow packages to build airflow. So far we always run the PROD build with `pip` that's why it worked fine, but once fix building with both uv and pip we can build the images with uv by default and run a pip build separately in extra checks. (cherry picked from commit 92a4d60) Fixes: #50134 Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
When we are building PROD image we use `pip` rather than `uv`, however we should be able to use `uv` to do it. Recently we had a bug that broke it - by using `--group dev` unconditionally - even if we used airflow packages to build airflow. So far we always run the PROD build with `pip` that's why it worked fine, but once fix building with both uv and pip we can build the images with uv by default and run a pip build separately in extra checks. Fixes: apache#50134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are building PROD image we use
piprather thanuv, however we should be able to useuvto do it. Recently we had a bug that broke it - by using--group devunconditionally - even if we used airflow packages to build airflow.So far we always run the PROD build with
pipthat's why it worked fine, but once fix building with both uv and pip we can build the images with uv by default and run a pip build separately in extra checks.Fixes: #50134
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.