[v3-0-test] Fix building PROD images with uv (#51277) #51289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we are building PROD image we use `pip` rather than `uv`, however we should be able to use `uv` to do it. Recently we had a bug that broke it - by using `--group dev` unconditionally - even if we used airflow packages to build airflow. So far we always run the PROD build with `pip` that's why it worked fine, but once fix building with both uv and pip we can build the images with uv by default and run a pip build separately in extra checks. (cherry picked from commit 92a4d60) Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Fixes: #50134
boring-cyborg
bot
added
area:dev-tools
area:production-image
hussein-awala
approved these changes
Jun 2, 2025
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
When we are building PROD image we use `pip` rather than `uv`, however we should be able to use `uv` to do it. Recently we had a bug that broke it - by using `--group dev` unconditionally - even if we used airflow packages to build airflow. So far we always run the PROD build with `pip` that's why it worked fine, but once fix building with both uv and pip we can build the images with uv by default and run a pip build separately in extra checks. (cherry picked from commit 92a4d60) Fixes: #50134 Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are building PROD image we use
piprather thanuv, howeverwe should be able to use
uvto do it. Recently we had a bug thatbroke it - by using
--group devunconditionally - even ifwe used airflow packages to build airflow.
So far we always run the PROD build with
pipthat's why it workedfine, but once fix building with both uv and pip we can build the
images with uv by default and run a pip build separately in extra
checks.
(cherry picked from commit 92a4d60)
Co-authored-by: Jarek Potiuk jarek@potiuk.com
Fixes: #50134