[v3-0-test] Ensure that both public and ui dags endpoints map to DagService (#51226) #51345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
bbovenzi,
bugraoz93,
ephraimbuddy,
jason810496,
jscheffl,
rawwar and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:API
pierrejeambrun
changed the title
…he#51226) Previously the dags router in ui endpoint was `Dags` while public was `DAG`. This resulted in the service being generated as DagsService for UI and DagService for public. But, probably better to have them generated under same service, and not just differ by the one letter. (cherry picked from commit c3861e7)
pierrejeambrun
force-pushed
the
backport-51226
branch
from
7abcb26 to
ce384b4
Compare
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
…) (#51345) Previously the dags router in ui endpoint was `Dags` while public was `DAG`. This resulted in the service being generated as DagsService for UI and DagService for public. But, probably better to have them generated under same service, and not just differ by the one letter. (cherry picked from commit c3861e7) Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the dags router in ui endpoint was
Dagswhile public wasDAG. This resulted in the service being generated as DagsService for UI and DagService for public. But, probably better to have them generated under same service, and not just differ by the one letter.(cherry picked from commit c3861e7)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.