Skip to content

Conversation

@ttencate
Copy link
Contributor

@ttencate ttencate commented Jun 3, 2025

Passing data="" did not work because it evaluates to False.

Made the same change for filename as well, so that filename="" will now give a clearer error when trying to open the file.

Passing data="" did not work because it evaluates to False.

Made the same change for filename as well, so that filename="" will now give a clearer error when trying to open the file.
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jun 3, 2025
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 3, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Contributor

@kiran2706 kiran2706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@potiuk
Copy link
Member

potiuk commented Jun 7, 2025

Can you please add unit tests ?

@ttencate
Copy link
Contributor Author

ttencate commented Jun 8, 2025

No, sorry. That'll turn a trivial five minute fix into a two hour ordeal figuring out your unit test structure, what and where to mock, how to run the tests, and dealing with spurious failures (I think CI already proved this above). I don't have time for that.

If you insist, I'd be happy to downgrade this PR into a bug report for someone else to pick up.

@kiran2706
Copy link
Contributor

@ttencate - I can add those test cases.

@ttencate
Copy link
Contributor Author

ttencate commented Jun 8, 2025

@kiran2706 Thank you!

@kiran2706
Copy link
Contributor

@ttencate / @potiuk , I've added the necessary test cases and created a new PR, as I unfortunately had trouble updating the original one directly.
Here’s the new PR link

Kindly review and merge it when convenient, and please close both PRs afterward.

#51669

@ttencate
Copy link
Contributor Author

Thank you @kiran2706 ! I'll go ahead and close this one, no need to keep it open until yours is merged.

@ttencate ttencate closed this Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants