Allow creation of empty files on GCS #51669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing data="" did not work because it evaluates to False. Made the same change for filename as well, so that filename="" will now give a clearer error when trying to open the file.
boring-cyborg
bot
added
area:providers
provider:google
Contributor
Author
|
@potiuk, Please review the changes. Thanks in advance. |
potiuk
approved these changes
Jun 13, 2025
choo121600
pushed a commit
to choo121600/airflow
that referenced
this pull request
Jun 14, 2025
* Allow creation of empty files on GCS Passing data="" did not work because it evaluates to False. Made the same change for filename as well, so that filename="" will now give a clearer error when trying to open the file. * added test cases --------- Co-authored-by: Thomas ten Cate <ttencate@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
upload()method allows empty strings ("") as valid values forfilenameanddatato support scenarios where uploading an intentionally empty file or data stream is required.
✔️ Examples of valid use cases:
_SUCCESSmarker).❗ Important distinctions:
filename=Noneanddata=None→ invalid (nothing to upload)filename != Noneanddata != None→ invalid (ambiguous source)filename=""→ valid, treated as explicit instruction to upload from an empty file pathdata=""→ valid, uploads an empty blobTo avoid accidental misuse, upstream callers should ensure that empty values are intentional.