Skip to content

Conversation

@laredoo
Copy link
Contributor

@laredoo laredoo commented Jun 4, 2025


This pull request is an extension of Do not dynamically determine op links for emr serverless start job operator. For the same reasons pointed out by @o-nikolas on his contribution, we extend the new behavior to AWS BatchOperator. It's also great to point that this PR should also addresses EmrServerlessStartJobOperator causes dag load failure when using XComArg under the context of BatchOperator.

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@laredoo laredoo requested review from eladkal and o-nikolas as code owners June 4, 2025 03:04
@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Jun 4, 2025
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 4, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Contributor

@o-nikolas o-nikolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you done some QA to ensure the links are greyed out as expected and available when expected? Including some screenshots would be nice if possible.

@laredoo
Copy link
Contributor Author

laredoo commented Jun 6, 2025

Have you done some QA to ensure the links are greyed out as expected and available when expected? Including some screenshots would be nice if possible.

In this case, it makes sense that none of these links are greyed out, since it's mandatory to have a job_definition and job_queue to instanciate a new BatchOperator and we're tracking logs through CloudWatch Events.

image

@o-nikolas
Copy link
Contributor

Have you done some QA to ensure the links are greyed out as expected and available when expected? Including some screenshots would be nice if possible.

In this case, it makes sense that none of these links are greyed out, since it's mandatory to have a job_definition and job_queue to instanciate a new BatchOperator and we're tracking logs through CloudWatch Events.

I see, fair enough, would be nice to see a case different than this one, to verify the behaviour for a case when the links used to be optional.

@laredoo
Copy link
Contributor Author

laredoo commented Jun 12, 2025

Have you done some QA to ensure the links are greyed out as expected and available when expected? Including some screenshots would be nice if possible.

In this case, it makes sense that none of these links are greyed out, since it's mandatory to have a job_definition and job_queue to instanciate a new BatchOperator and we're tracking logs through CloudWatch Events.

I see, fair enough, would be nice to see a case different than this one, to verify the behaviour for a case when the links used to be optional.

In this case, the only optional link I could think of would be the CloudWatchEvents, and disabling it could be achieved by setting the awslogs_enabled as false, thus disabling the CloudWatchEventsLink.

By doing so it worked out smoothly, greying out the link as expected:

image

In the source code, this is basically how I am calling the operator:

image

@o-nikolas o-nikolas merged commit 2fd8a7e into apache:main Jun 19, 2025
71 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 19, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

RoyLee1224 pushed a commit to RoyLee1224/airflow that referenced this pull request Jun 21, 2025
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants