-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Do not dynamically determine operator extra links for BatchOperator #51385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
o-nikolas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you done some QA to ensure the links are greyed out as expected and available when expected? Including some screenshots would be nice if possible.
In this case, it makes sense that none of these links are greyed out, since it's mandatory to have a job_definition and job_queue to instanciate a new BatchOperator and we're tracking logs through CloudWatch Events. |
I see, fair enough, would be nice to see a case different than this one, to verify the behaviour for a case when the links used to be optional. |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>



This pull request is an extension of Do not dynamically determine op links for emr serverless start job operator. For the same reasons pointed out by @o-nikolas on his contribution, we extend the new behavior to AWS BatchOperator. It's also great to point that this PR should also addresses EmrServerlessStartJobOperator causes dag load failure when using XComArg under the context of BatchOperator.
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.