fix(migrations): only ignore ValueError when interacting with constraints in sqlite #51529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
force-pushed
the
fix-3-0-0-migration
branch
from
6251dd7 to
f25b5d5
Compare
Lee-W
changed the title
Lee-W
added
the
backport-to-v3-1-test
Lee-W
force-pushed
the
fix-3-0-0-migration
branch
from
f25b5d5 to
dd97079
Compare
…aints in sqlite The original syntax will ignore the whole batch if a ValueError is encountered. The migration process will work, but wrongly. In this example, dag_run.created_at will not be created for SQLite, which will cause an error when running Airflow.
Lee-W
force-pushed
the
fix-3-0-0-migration
branch
from
dd97079 to
3e99069
Compare
uranusjr
approved these changes
Jun 11, 2025
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker c74ecd4 v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
Lee-W
removed
the
backport-to-v3-1-test
Lee-W
added a commit
to astronomer/airflow
that referenced
this pull request
Jun 12, 2025
… with constraints in sqlite (apache#51529) The original syntax will ignore the whole batch if a ValueError is encountered. The migration process will work, but wrongly. In this example, dag_run.created_at will not be created for SQLite, which will cause an error when running Airflow. (cherry picked from commit c74ecd4) Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The original syntax will ignore the whole batch if a ValueError is encountered. The migration process will work, but wrongly.
In this example, dag_run.created_at will not be created for SQLite, which will cause an error when running Airflow.
This was wrongly fixed in #51336
What
Only ignore ValueError when interacting with constraints in SQLite
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.