Skip to content

fix(migrations): only ignore ValueError when interacting with constraints in sqlite #51529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lee-W merged 1 commit into from
Jun 11, 2025
Merged

fix(migrations): only ignore ValueError when interacting with constraints in sqlite #51529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airflow-core/docs/img/airflow_erd.sha256
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
173317aa67c36d8a257bc31c99eeedf906390cebdd9c6941d6e9c3db0515d5c5
71743446a269a520d2a6a9511eff99d7fc8c4b0409ba58b4bc3b2e1fee195774
5 changes: 5 additions & 0 deletions airflow-core/src/airflow/migrations/versions/0047_3_0_0_add_dag_versioning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,11 @@ def upgrade():
sa.PrimaryKeyConstraint("id", name=op.f("dag_version_pkey")),
sa.UniqueConstraint("dag_id", "version_number", name="dag_id_v_name_v_number_unique_constraint"),
)

with ignore_sqlite_value_error(), op.batch_alter_table("dag_code") as batch_op:
batch_op.drop_constraint("dag_code_pkey", type_="primary")

with op.batch_alter_table("dag_code") as batch_op:
batch_op.drop_column("fileloc_hash")
batch_op.add_column(sa.Column("id", UUIDType(binary=False), nullable=False))
batch_op.create_primary_key("dag_code_pkey", ["id"])
Expand All @@ -91,6 +94,8 @@ def upgrade():

with ignore_sqlite_value_error(), op.batch_alter_table("serialized_dag") as batch_op:
batch_op.drop_constraint("serialized_dag_pkey", type_="primary")

with op.batch_alter_table("serialized_dag") as batch_op:
batch_op.drop_index("idx_fileloc_hash")
batch_op.drop_column("fileloc_hash")
batch_op.drop_column("fileloc")
Expand Down