Add bulk TI deletion UI #51564

guan404ming · 2025-06-10T08:46:47Z

Related PR

this one is the follow up pr of Add TI bulk actions endpoint #50443 to implement bulk TI deletion ui

How

add multi-select in ti table
minor fix in bulk TI deletion endpoint

Screen.Recording.2025-06-10.at.4.40.43.PM.mov

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

airflow-core/src/airflow/ui/src/pages/TaskInstances/DeleteTaskInstancesButton.tsx

guan404ming · 2025-06-12T18:56:07Z

I have updated the translation and try reuse AffectedTasks
Current ui looks like:

Screen.Recording.2025-06-13.at.2.39.31.AM.mov

airflow-core/src/airflow/ui/src/pages/TaskInstances/DeleteTaskInstancesButton.tsx

airflow-core/src/airflow/ui/src/pages/TaskInstances/TaskInstances.tsx

airflow-core/src/airflow/ui/src/queries/useBulkDeleteTaskInstances.ts

pierrejeambrun

For mapped task instance the confirmation table is not correct, cf screenshot, actually 4 TIs are selected (3 mapped TI and 1 non mapped TI), and the modal only show 2 TIs)

airflow-core/src/airflow/ui/src/queries/useBulkDeleteTaskInstances.ts

guan404ming · 2025-06-13T15:10:27Z

For mapped task instance the confirmation table is not correct, cf screenshot, actually 4 TIs are selected (3 mapped TI and 1 non mapped TI), and the modal only show 2 TIs)

The api needs some modification for handling ti with map_index as well. Let me mark this as draft.

pierrejeambrun · 2025-06-16T15:50:40Z

The api needs some modification for handling ti with map_index as well. Let me mark this as draft.

Thanks @guan404ming, do not hesitate to create a different PR for the backend part so it's easier to review and merge. (and you can rebase this branch on top of the backend change to test it locally)

pierrejeambrun

This was introduced in #50165 to fix #50104 to try to get feature parity with 2.x.

The goal was to be able to remove both TIs and DagRuns.

It seems like the singular TI deletion is already in our UI and API

Yes, as well as singular dag run. Both in API and UI.

-1. We should never delete TIs and TIH. This shouldn't even be a feature in the API!

@ashb I guess this also goes for dag runs. Should we go ahead and remove all of that from API and UI ?

cc: @bbovenzi

ashb · 2025-09-16T16:13:16Z

I guess it's up to users if they want to do it, but we should probably make it 100% clear it will delete all history and audit records of the TI.

I don't personally like it, but now I think about it more I'm not sure that we should stop users from being able to do this if they want to.

Maybe a future change to add a config option to disable deleteing them at the deploy level

bbovenzi · 2025-09-16T18:11:23Z

I guess it's up to users if they want to do it, but we should probably make it 100% clear it will delete all history and audit records of the TI.

I don't personally like it, but now I think about it more I'm not sure that we should stop users from being able to do this if they want to.

Maybe a future change to add a config option to disable deleteing them at the deploy level

How about we update the copy "This will remove all metadata related" and spell out what will be deleted?

FrankPortman · 2025-09-25T12:01:49Z

Not being able to easily sort/search-by-params/delete runs/TIs in bulk is a big con of AF3 for our use case.

pierrejeambrun · 2025-09-30T15:07:49Z

@guan404ming any progress on this one ? I think a UI warning could suffice as mentioned by Brent, and unblock this.

guan404ming · 2025-10-02T16:05:20Z

@guan404ming any progress on this one ? I think a UI warning could suffice as mentioned by Brent, and unblock this.

Sure! I'm also agree with this solution. I've update the warning to a more detailed version, please let me if it could be better. Thanks!

airflow-core/src/airflow/ui/src/queries/useBulkDeleteTaskInstances.ts

airflow-core/src/airflow/ui/src/queries/useBulkPatchTaskInstances.ts

guan404ming · 2025-12-10T10:14:30Z

I've updated to work with new endpoint. Please take another look, thanks!

pierrejeambrun

On my end, the mark as 'success' 'delete' is not working everytime. Request goes to the backend, and is successful, but it's just not updating the state of the tasks.

Screen.Recording.2025-12-10.at.15.59.45.mov

Also deleting a TI can leave a 'unfound tasks' in the UI, here task 1 was deleted.

I think there are a lot of edge cases to consider, and we need extensive testing / fixes for it to work. This is a complex feature to get right.

Also the crosshair is truncated

pierrejeambrun · 2025-12-10T14:55:56Z

airflow-core/src/airflow/ui/src/components/MarkAs/TaskInstances/MarkTaskInstancesAsDialog.tsx

+        </Dialog.Header>
+
+        <Dialog.CloseTrigger />
+
+        <Dialog.Body width="full">
+          <ActionAccordion affectedTasks={affectedTasks} note={note} setNote={setNote} />
+          <Flex justifyContent="end" mt={3}>
+            <Button colorPalette="blue" loading={isPending} onClick={() => handlePatch(selectedState)}>
+              {translate("modal.confirm")}
+            </Button>
+          </Flex>
+        </Dialog.Body>


We are missing the selector,

I guess it's fine for now since we use the 'bulk' endpoint.

pierrejeambrun · 2025-12-10T14:56:28Z

airflow-core/src/airflow/ui/src/queries/useBulkDeleteTaskInstances.ts

+  const onSuccess = async (responseData: { delete?: { errors: Array<unknown>; success: Array<string> } }) => {
+    const queryKeys = [
+      [useTaskInstanceServiceGetTaskInstancesKey],
+      dagId === undefined || dagRunId === undefined
+        ? []
+        : [UseGridServiceGetGridTiSummariesKeyFn({ dagId, runId: dagRunId })],
+    ];
+


Grid is not updated after a successful delete. We should probably do that too. cf video. (clearing tasks from the same run)

pierrejeambrun · 2025-12-10T14:56:40Z

airflow-core/src/airflow/ui/src/queries/useBulkPatchTaskInstances.ts

+    const queryKeys = [
+      [useTaskInstanceServiceGetTaskInstancesKey],
+      dagId === undefined || dagRunId === undefined
+        ? []


Lee-W · 2026-01-09T08:18:03Z

@guan404ming would like to follow up whehter wer're still working on this one?

Lee-W · 2026-01-09T08:18:27Z

I'm now making it a draft. Feel free to mark it as ready

guan404ming · 2026-01-17T18:25:42Z

Apologies for the delay. This PR has become stale, and I noticed there are other active PRs addressing the same issue. To avoid redundancy, I’ll go ahead and close this one. Thank you everyone for your time and reviews.

guan404ming · 2026-01-17T18:39:03Z

I think splitting this into several PRs is a better approach. I’ll figure out the remaining gaps and open targeted PRs accordingly. I’m also happy to help review other open PRs for this feature to avoid overlapping work.

guan404ming requested review from bbovenzi, bugraoz93, ephraimbuddy, jason810496, jscheffl, pierrejeambrun, rawwar, ryanahamilton and shubhamraj-git as code owners June 10, 2025 08:46

boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Jun 10, 2025

guan404ming force-pushed the bulk-ti-ui branch 2 times, most recently from 1adc30a to 3376842 Compare June 10, 2025 10:15

jscheffl reviewed Jun 10, 2025

View reviewed changes

airflow-core/src/airflow/ui/src/pages/TaskInstances/DeleteTaskInstancesButton.tsx Outdated Show resolved Hide resolved

guan404ming marked this pull request as draft June 11, 2025 19:02

bbovenzi reviewed Jun 12, 2025

View reviewed changes

airflow-core/src/airflow/ui/src/pages/TaskInstances/DeleteTaskInstancesButton.tsx Outdated Show resolved Hide resolved

guan404ming force-pushed the bulk-ti-ui branch from 3376842 to b1d495a Compare June 12, 2025 18:54

guan404ming marked this pull request as ready for review June 12, 2025 18:56

bbovenzi reviewed Jun 12, 2025

View reviewed changes

airflow-core/src/airflow/ui/src/pages/TaskInstances/DeleteTaskInstancesButton.tsx Outdated Show resolved Hide resolved

bbovenzi reviewed Jun 12, 2025

View reviewed changes

airflow-core/src/airflow/ui/src/pages/TaskInstances/TaskInstances.tsx Outdated Show resolved Hide resolved

bbovenzi reviewed Jun 12, 2025

View reviewed changes

airflow-core/src/airflow/ui/src/queries/useBulkDeleteTaskInstances.ts Outdated Show resolved Hide resolved

pierrejeambrun added this to the Airflow 3.1.0 milestone Jun 13, 2025

pierrejeambrun reviewed Jun 13, 2025

View reviewed changes

airflow-core/src/airflow/ui/src/queries/useBulkDeleteTaskInstances.ts Outdated Show resolved Hide resolved

guan404ming force-pushed the bulk-ti-ui branch from b1d495a to db123d8 Compare June 13, 2025 15:08

guan404ming requested a review from Lee-W as a code owner June 13, 2025 15:08

guan404ming marked this pull request as draft June 13, 2025 15:10

guan404ming force-pushed the bulk-ti-ui branch from 49f28b6 to da4bc4a Compare September 8, 2025 08:50

kaxil modified the milestones: Airflow 3.1.0, Airflow 3.1+ Sep 9, 2025

pierrejeambrun reviewed Sep 16, 2025

View reviewed changes

guan404ming force-pushed the bulk-ti-ui branch from da4bc4a to fa1c720 Compare October 2, 2025 16:02

pierrejeambrun reviewed Oct 13, 2025

View reviewed changes

airflow-core/src/airflow/ui/src/queries/useBulkDeleteTaskInstances.ts Outdated Show resolved Hide resolved

airflow-core/src/airflow/ui/src/queries/useBulkPatchTaskInstances.ts Outdated Show resolved Hide resolved

guan404ming marked this pull request as draft October 15, 2025 08:28

guan404ming and others added 8 commits December 10, 2025 17:54

Add bulk TI deletion UI

7c49615

Separate translation descriptions for each action

d8529be

Handle cross dag bulk deletion

8e2eff5

Add bulk mark as UI

1898b9c

Add incremental success msg

d599a72

Update warning to more detailed version

4071206

Remove unused eslint-disable

a581742

Update to use wildcard supported endpoint

9c0611e

guan404ming force-pushed the bulk-ti-ui branch from 9bda958 to 9c0611e Compare December 10, 2025 10:03

guan404ming marked this pull request as ready for review December 10, 2025 10:13

pierrejeambrun reviewed Dec 10, 2025

View reviewed changes

Lee-W marked this pull request as draft January 9, 2026 08:18

guan404ming closed this Jan 17, 2026

Add bulk TI deletion UI #51564

Add bulk TI deletion UI #51564

Uh oh!

Conversation

guan404ming commented Jun 10, 2025

Related PR

How

Uh oh!

Uh oh!

Uh oh!

guan404ming commented Jun 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pierrejeambrun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

guan404ming commented Jun 13, 2025

Uh oh!

pierrejeambrun commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pierrejeambrun left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ashb commented Sep 16, 2025

Uh oh!

bbovenzi commented Sep 16, 2025

Uh oh!

FrankPortman commented Sep 25, 2025

Uh oh!

pierrejeambrun commented Sep 30, 2025

Uh oh!

guan404ming commented Oct 2, 2025

Uh oh!

Uh oh!

Uh oh!

guan404ming commented Dec 10, 2025

Uh oh!

pierrejeambrun left a comment

Choose a reason for hiding this comment

Uh oh!

pierrejeambrun Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

pierrejeambrun Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

pierrejeambrun Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pierrejeambrun Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

Lee-W commented Jan 9, 2026

Uh oh!

Lee-W commented Jan 9, 2026

Uh oh!

guan404ming commented Jan 17, 2026

Uh oh!

guan404ming commented Jan 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

pierrejeambrun commented Jun 16, 2025 •

edited

Loading

pierrejeambrun left a comment •

edited

Loading

pierrejeambrun Dec 10, 2025 •

edited

Loading