Skip to content

Add TI bulk actions endpoint #50443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bbovenzi merged 1 commit into from
May 29, 2025
Merged

Add TI bulk actions endpoint #50443

bbovenzi merged 1 commit into from
May 29, 2025

Conversation

@guan404ming
Copy link
Member

@guan404ming guan404ming commented May 10, 2025 •
edited
Loading

Related Issue

#50396

Why

We need bulk endpoint to support mulit-selection in ui thus this PR focus on implementation of TI bulk actions api

How

  • implement it based on connection, pool and variable bulk endpoint
  • override the BulkService to pass dag_id and dag_run_id

Not sure if we should let users create TI by themselves thus I didn't implement it now. If needed, I could add it.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:airflow-ctl area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels May 10, 2025
@guan404ming guan404ming force-pushed the bulk_ti branch 4 times, most recently from b89a043 to 4cbd650 Compare May 11, 2025 11:02
@guan404ming guan404ming mentioned this pull request May 11, 2025
Merged
@guan404ming guan404ming marked this pull request as ready for review May 11, 2025 11:41
bugraoz93
bugraoz93 reviewed May 11, 2025
View reviewed changes
Copy link
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Direction looks good small suggestions :)

@guan404ming guan404ming force-pushed the bulk_ti branch 2 times, most recently from f108c5e to 2a514f3 Compare May 11, 2025 16:12
@raphaelauv raphaelauv mentioned this pull request May 11, 2025
Closed
2 tasks
@guan404ming guan404ming force-pushed the bulk_ti branch 3 times, most recently from 3302d39 to f7e49d1 Compare May 14, 2025 12:05
@guan404ming guan404ming force-pushed the bulk_ti branch 2 times, most recently from d98dc8d to f53d5f5 Compare May 25, 2025 13:58
@guan404ming
Copy link
Member Author

guan404ming commented May 25, 2025

Hi, @pierrejeambrun @bugraoz93
I think the ci error do related to my change since it works normally on main and only fails here. But I couldn't find the root cause for it in several days of trying. Do you know any possible direction or something could cause k8s test crush? I could keep doing more research and testing. Thanks in advance!

@pierrejeambrun
Copy link
Member

pierrejeambrun commented May 26, 2025

I'm not sure, did you try rebasing a couple of times, maybe that's no directly related because the server is not starting.

@guan404ming
Copy link
Member Author

guan404ming commented May 27, 2025 •
edited
Loading

I've tried rebase it multiple times and I've also add longer timeout and retry for the k8s check but it seems not works. Let me rebase it again. Thanks!

jason810496
jason810496 reviewed May 28, 2025
View reviewed changes
Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @guan404ming, I found a small difference, not sure does this difference related to the CI error.

It's weird that k8s test fail at ensure_resource_health("airflow-api-server") 😟

@guan404ming guan404ming force-pushed the bulk_ti branch 3 times, most recently from 99fd2b1 to 6431549 Compare May 29, 2025 05:27
jason810496
jason810496 requested changes May 29, 2025
View reviewed changes
@guan404ming guan404ming marked this pull request as ready for review May 29, 2025 13:46
@guan404ming
Copy link
Member Author

guan404ming commented May 29, 2025

It works, thanks @jason810496 !

@bbovenzi bbovenzi added this to the Airflow 3.1.0 milestone May 29, 2025
@bbovenzi bbovenzi merged commit f8e2916 into apache:main May 29, 2025
98 of 126 checks passed
@guan404ming
Copy link
Member Author

guan404ming commented May 29, 2025

Thanks for all reviews and suggestions.

@guan404ming guan404ming deleted the bulk_ti branch May 29, 2025 16:40
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
@guan404ming @sanederchik
Add TI bulk actions endpoint (apache#50443)
62dcda1
This was referenced Jun 9, 2025
Merged
Closed
jose-lehmkuhl pushed a commit to jose-lehmkuhl/airflow that referenced this pull request Jul 11, 2025
@guan404ming @jose-lehmkuhl
Add TI bulk actions endpoint (apache#50443)
ce16128
kaxil added a commit to apache/airflow-client-python that referenced this pull request Oct 22, 2025
@kaxil
Update Python Client to 3.1.0rc1
e62c042 
(from https://github.com/apache/airflow/tree/python-client/3.1.0rc1)

## New Features:

- Add `map_index` filter to TaskInstance API queries ([#55614](apache/airflow#55614))
- Add `has_import_errors` filter to Core API GET /dags endpoint ([#54563](apache/airflow#54563))
- Add `dag_version` filter to get_dag_runs endpoint ([#54882](apache/airflow#54882))
- Implement pattern search for event log endpoint ([#55114](apache/airflow#55114))
- Add asset-based filtering support to DAG API endpoint ([#54263](apache/airflow#54263))
- Add Greater Than and Less Than range filters to DagRuns and Task Instance list ([#54302](apache/airflow#54302))
- Add `try_number` as filter to task instances ([#54695](apache/airflow#54695))
- Add filters to Browse XComs endpoint ([#54049](apache/airflow#54049))
- Add Filtering by DAG Bundle Name and Version to API routes ([#54004](apache/airflow#54004))
- Add search filter for DAG runs by triggering user name ([#53652](apache/airflow#53652))
- Enable multi sorting (AIP-84) ([#53408](apache/airflow#53408))
- Add `run_on_latest_version` support for backfill and clear operations ([#52177](apache/airflow#52177))
- Add `run_id_pattern` search for Dag Run API ([#52437](apache/airflow#52437))
- Add tracking of triggering user to Dag runs ([#51738](apache/airflow#51738))
- Expose DAG parsing duration in the API ([#54752](apache/airflow#54752))

## New API Endpoints:

- Add Human-in-the-Loop (HITL) endpoints for approval workflows ([#52868](apache/airflow#52868), [#53373](apache/airflow#53373), [#53376](apache/airflow#53376), [#53885](apache/airflow#53885), [#53923](apache/airflow#53923), [#54308](apache/airflow#54308), [#54310](apache/airflow#54310), [#54723](apache/airflow#54723), [#54773](apache/airflow#54773), [#55019](apache/airflow#55019), [#55463](apache/airflow#55463), [#55525](apache/airflow#55525), [#55535](apache/airflow#55535), [#55603](apache/airflow#55603), [#55776](apache/airflow#55776))
- Add endpoint to watch dag run until finish ([#51920](apache/airflow#51920))
- Add TI bulk actions endpoint ([#50443](apache/airflow#50443))
- Add Keycloak Refresh Token Endpoint ([#51657](apache/airflow#51657))

## Deprecations:

- Mark `DagDetailsResponse.concurrency` as deprecated ([#55150](apache/airflow#55150))

## Bug Fixes:

- Fix dag import error modal pagination ([#55719](apache/airflow#55719))
@kaxil kaxil mentioned this pull request Oct 22, 2025
Merged
kaxil added a commit to apache/airflow-client-python that referenced this pull request Oct 23, 2025
@kaxil
Update Python Client to 3.1.0rc1 (#138)
241405e 
(from https://github.com/apache/airflow/tree/python-client/3.1.0rc1)

## New Features:

- Add `map_index` filter to TaskInstance API queries ([#55614](apache/airflow#55614))
- Add `has_import_errors` filter to Core API GET /dags endpoint ([#54563](apache/airflow#54563))
- Add `dag_version` filter to get_dag_runs endpoint ([#54882](apache/airflow#54882))
- Implement pattern search for event log endpoint ([#55114](apache/airflow#55114))
- Add asset-based filtering support to DAG API endpoint ([#54263](apache/airflow#54263))
- Add Greater Than and Less Than range filters to DagRuns and Task Instance list ([#54302](apache/airflow#54302))
- Add `try_number` as filter to task instances ([#54695](apache/airflow#54695))
- Add filters to Browse XComs endpoint ([#54049](apache/airflow#54049))
- Add Filtering by DAG Bundle Name and Version to API routes ([#54004](apache/airflow#54004))
- Add search filter for DAG runs by triggering user name ([#53652](apache/airflow#53652))
- Enable multi sorting (AIP-84) ([#53408](apache/airflow#53408))
- Add `run_on_latest_version` support for backfill and clear operations ([#52177](apache/airflow#52177))
- Add `run_id_pattern` search for Dag Run API ([#52437](apache/airflow#52437))
- Add tracking of triggering user to Dag runs ([#51738](apache/airflow#51738))
- Expose DAG parsing duration in the API ([#54752](apache/airflow#54752))

## New API Endpoints:

- Add Human-in-the-Loop (HITL) endpoints for approval workflows ([#52868](apache/airflow#52868), [#53373](apache/airflow#53373), [#53376](apache/airflow#53376), [#53885](apache/airflow#53885), [#53923](apache/airflow#53923), [#54308](apache/airflow#54308), [#54310](apache/airflow#54310), [#54723](apache/airflow#54723), [#54773](apache/airflow#54773), [#55019](apache/airflow#55019), [#55463](apache/airflow#55463), [#55525](apache/airflow#55525), [#55535](apache/airflow#55535), [#55603](apache/airflow#55603), [#55776](apache/airflow#55776))
- Add endpoint to watch dag run until finish ([#51920](apache/airflow#51920))
- Add TI bulk actions endpoint ([#50443](apache/airflow#50443))
- Add Keycloak Refresh Token Endpoint ([#51657](apache/airflow#51657))

## Deprecations:

- Mark `DagDetailsResponse.concurrency` as deprecated ([#55150](apache/airflow#55150))

## Bug Fixes:

- Fix dag import error modal pagination ([#55719](apache/airflow#55719))
@itayweb itayweb mentioned this pull request Nov 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bugraoz93 bugraoz93 bugraoz93 approved these changes

@pierrejeambrun pierrejeambrun pierrejeambrun left review comments

@bbovenzi bbovenzi bbovenzi approved these changes

@jason810496 jason810496 jason810496 approved these changes

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@jscheffl jscheffl Awaiting requested review from jscheffl

@shubhamraj-git shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner

@kaxil kaxil Awaiting requested review from kaxil

@potiuk potiuk Awaiting requested review from potiuk potiuk is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

@rawwar rawwar Awaiting requested review from rawwar rawwar is a code owner

Assignees

No one assigned

Labels

area:airflow-ctl area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Milestone

Airflow 3.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@guan404ming @bugraoz93 @pierrejeambrun @bbovenzi @jason810496