-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add map_index filter to TaskInstance API queries #55614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2fbe7af to
acfad88
Compare
jason810496
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for the PR!
The expected TI count doesn’t seem correct to me, even though the CI passed. Could you please double check the logic? Thanks!
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_task_instances.py
Outdated
Show resolved
Hide resolved
01066c5 to
ae61bc3
Compare
ae61bc3 to
5c7ad2d
Compare
|
@jason810496 @eladkal I have moved it to 3.2. I assume since UI isn't going to have this filter ready for 3.1, there isn't much benefit of this in 3.1. Feel free to disagree though and let me know if there is a reason to include it in 3.1 |
LGTM for moving to 3.2, but I think it depends on whether the Gantt Chart refactor is included. |
* Add QueryTIMapIndexFilter to API parameters for task instance queries * Update test case to prevent confusion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to have it in 3.1 since this PR has already integrated the changes in UI here.
LGTM for moving to 3.2, but I think it depends on whether the Gantt Chart refactor is included.
All the other fix / refactor about Gantt chart are in 3.1.
* Add QueryTIMapIndexFilter to API parameters for task instance queries * Update test case to prevent confusion (cherry picked from commit 62fbe01)
* Add QueryTIMapIndexFilter to API parameters for task instance queries * Update test case to prevent confusion (cherry picked from commit 62fbe01)
* Add QueryTIMapIndexFilter to API parameters for task instance queries * Update test case to prevent confusion
* Add QueryTIMapIndexFilter to API parameters for task instance queries * Update test case to prevent confusion
* Add QueryTIMapIndexFilter to API parameters for task instance queries * Update test case to prevent confusion
* Add QueryTIMapIndexFilter to API parameters for task instance queries * Update test case to prevent confusion
* Add QueryTIMapIndexFilter to API parameters for task instance queries * Update test case to prevent confusion
* Add QueryTIMapIndexFilter to API parameters for task instance queries * Update test case to prevent confusion
* Add QueryTIMapIndexFilter to API parameters for task instance queries * Update test case to prevent confusion
* Add QueryTIMapIndexFilter to API parameters for task instance queries * Update test case to prevent confusion
* Add QueryTIMapIndexFilter to API parameters for task instance queries * Update test case to prevent confusion
* Add QueryTIMapIndexFilter to API parameters for task instance queries * Update test case to prevent confusion
* Add QueryTIMapIndexFilter to API parameters for task instance queries * Update test case to prevent confusion
* Add QueryTIMapIndexFilter to API parameters for task instance queries * Update test case to prevent confusion
* Add QueryTIMapIndexFilter to API parameters for task instance queries * Update test case to prevent confusion
* Add QueryTIMapIndexFilter to API parameters for task instance queries * Update test case to prevent confusion
* Add QueryTIMapIndexFilter to API parameters for task instance queries * Update test case to prevent confusion
* Add QueryTIMapIndexFilter to API parameters for task instance queries * Update test case to prevent confusion
* Add QueryTIMapIndexFilter to API parameters for task instance queries * Update test case to prevent confusion
* Add QueryTIMapIndexFilter to API parameters for task instance queries * Update test case to prevent confusion
(from https://github.com/apache/airflow/tree/python-client/3.1.0rc1) ## New Features: - Add `map_index` filter to TaskInstance API queries ([#55614](apache/airflow#55614)) - Add `has_import_errors` filter to Core API GET /dags endpoint ([#54563](apache/airflow#54563)) - Add `dag_version` filter to get_dag_runs endpoint ([#54882](apache/airflow#54882)) - Implement pattern search for event log endpoint ([#55114](apache/airflow#55114)) - Add asset-based filtering support to DAG API endpoint ([#54263](apache/airflow#54263)) - Add Greater Than and Less Than range filters to DagRuns and Task Instance list ([#54302](apache/airflow#54302)) - Add `try_number` as filter to task instances ([#54695](apache/airflow#54695)) - Add filters to Browse XComs endpoint ([#54049](apache/airflow#54049)) - Add Filtering by DAG Bundle Name and Version to API routes ([#54004](apache/airflow#54004)) - Add search filter for DAG runs by triggering user name ([#53652](apache/airflow#53652)) - Enable multi sorting (AIP-84) ([#53408](apache/airflow#53408)) - Add `run_on_latest_version` support for backfill and clear operations ([#52177](apache/airflow#52177)) - Add `run_id_pattern` search for Dag Run API ([#52437](apache/airflow#52437)) - Add tracking of triggering user to Dag runs ([#51738](apache/airflow#51738)) - Expose DAG parsing duration in the API ([#54752](apache/airflow#54752)) ## New API Endpoints: - Add Human-in-the-Loop (HITL) endpoints for approval workflows ([#52868](apache/airflow#52868), [#53373](apache/airflow#53373), [#53376](apache/airflow#53376), [#53885](apache/airflow#53885), [#53923](apache/airflow#53923), [#54308](apache/airflow#54308), [#54310](apache/airflow#54310), [#54723](apache/airflow#54723), [#54773](apache/airflow#54773), [#55019](apache/airflow#55019), [#55463](apache/airflow#55463), [#55525](apache/airflow#55525), [#55535](apache/airflow#55535), [#55603](apache/airflow#55603), [#55776](apache/airflow#55776)) - Add endpoint to watch dag run until finish ([#51920](apache/airflow#51920)) - Add TI bulk actions endpoint ([#50443](apache/airflow#50443)) - Add Keycloak Refresh Token Endpoint ([#51657](apache/airflow#51657)) ## Deprecations: - Mark `DagDetailsResponse.concurrency` as deprecated ([#55150](apache/airflow#55150)) ## Bug Fixes: - Fix dag import error modal pagination ([#55719](apache/airflow#55719))
(from https://github.com/apache/airflow/tree/python-client/3.1.0rc1) ## New Features: - Add `map_index` filter to TaskInstance API queries ([#55614](apache/airflow#55614)) - Add `has_import_errors` filter to Core API GET /dags endpoint ([#54563](apache/airflow#54563)) - Add `dag_version` filter to get_dag_runs endpoint ([#54882](apache/airflow#54882)) - Implement pattern search for event log endpoint ([#55114](apache/airflow#55114)) - Add asset-based filtering support to DAG API endpoint ([#54263](apache/airflow#54263)) - Add Greater Than and Less Than range filters to DagRuns and Task Instance list ([#54302](apache/airflow#54302)) - Add `try_number` as filter to task instances ([#54695](apache/airflow#54695)) - Add filters to Browse XComs endpoint ([#54049](apache/airflow#54049)) - Add Filtering by DAG Bundle Name and Version to API routes ([#54004](apache/airflow#54004)) - Add search filter for DAG runs by triggering user name ([#53652](apache/airflow#53652)) - Enable multi sorting (AIP-84) ([#53408](apache/airflow#53408)) - Add `run_on_latest_version` support for backfill and clear operations ([#52177](apache/airflow#52177)) - Add `run_id_pattern` search for Dag Run API ([#52437](apache/airflow#52437)) - Add tracking of triggering user to Dag runs ([#51738](apache/airflow#51738)) - Expose DAG parsing duration in the API ([#54752](apache/airflow#54752)) ## New API Endpoints: - Add Human-in-the-Loop (HITL) endpoints for approval workflows ([#52868](apache/airflow#52868), [#53373](apache/airflow#53373), [#53376](apache/airflow#53376), [#53885](apache/airflow#53885), [#53923](apache/airflow#53923), [#54308](apache/airflow#54308), [#54310](apache/airflow#54310), [#54723](apache/airflow#54723), [#54773](apache/airflow#54773), [#55019](apache/airflow#55019), [#55463](apache/airflow#55463), [#55525](apache/airflow#55525), [#55535](apache/airflow#55535), [#55603](apache/airflow#55603), [#55776](apache/airflow#55776)) - Add endpoint to watch dag run until finish ([#51920](apache/airflow#51920)) - Add TI bulk actions endpoint ([#50443](apache/airflow#50443)) - Add Keycloak Refresh Token Endpoint ([#51657](apache/airflow#51657)) ## Deprecations: - Mark `DagDetailsResponse.concurrency` as deprecated ([#55150](apache/airflow#55150)) ## Bug Fixes: - Fix dag import error modal pagination ([#55719](apache/airflow#55719))
Why
Since gantt chart needs to fetch non-mapped TI (map_index == -1), it would be more efficient for frontend to have map_index filter for the related endpoints.
How
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.