AIP-86: Add deadline to DagResponse
#51698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:airflow-ctl
area:API
rawwar
requested review from
bbovenzi,
bugraoz93,
ephraimbuddy,
jason810496,
jscheffl,
kaxil,
pierrejeambrun,
potiuk,
rawwar,
ryanahamilton and
shubhamraj-git
as code owners
jscheffl
approved these changes
Jun 15, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
This is just adding the models, no logic until here?
Contributor
Author
@jscheffl Yep! |
Member
|
There is already a PR opened to do that (and also add the necessary logic outside of dag models) |
Contributor
|
FYI: You just linked to this same PR. I think perhaps you meant #50957 ? |
Contributor
|
Were you able to test this at all? I'm getting failures because the current dag code still only accepts a single deadline, not a list yet. https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/models/dag.py#L377 Pretty sure this can't work as written until the dag model is adjusted to accept a list of deadlines? |
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Jun 21, 2025
* add deadline to DagResponse * add deadline to DagResponse * fix: CI test fails by adding deadline field to get_dagbag_dag_details() func --------- Co-authored-by: kalyanr <kalyan.ben10@live.com>
ferruzzi
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jul 8, 2025
This reverts commit 7c31bb5
ferruzzi
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jul 21, 2025
This reverts commit 7c31bb5
ferruzzi
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jul 21, 2025
This reverts commit 7c31bb5
o-nikolas
pushed a commit
that referenced
this pull request
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #50991