-
Notifications
You must be signed in to change notification settings - Fork 16.3k
use of debugpy to run airflow components via breeze #51763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty cool!
Can you add something about this into the Contribution docs as well?
...and would it make sense adding this to breeze CLI as command line instead of ENV?
Yes. I'm adding CLI support as well. And, I'll update docs. |
Very much agree with Jens here .... and that's nice. I usually use intelliJ's debug server, there, it works a bit differently (you need to add debug code to connect to server running in IntelliJ) - but maybe we could do something similar. |
I just looked into how to do this in PyCharm and yeah, its different. No option to directly connect to debugpy. But, I'll look into it and add something similar |
|
Let's get it in, I can add Pycharm debugging as follow up :) |
|
BTW. We will need a section in the contributing docs describing it (including your examples how to configure it in vscode :) |
Yeah. I've been struggling on how to make this work with pycharm. With VSCode, I was done almost 2 weeks ago. Been trying to figure out how remote debbing works with pycharm. Thank you! I'll work on updating docs and get this merged first |
90cdf5a to
a0dea54
Compare
When debugger option has been added to breeze in apache#51763 - the ports were added to base-port.yml, but the environment variables were only set when debugging is enabled. This hower caused warnings that the variables are not set and defaulting them to empty string when no debug components were used. Instead - we moved the debugger ports to separate compose file and only use the compose file when debug components are used.
When debugger option has been added to breeze in apache#51763 - the ports were added to base-port.yml, but the environment variables were only set when debugging is enabled. This hower caused warnings that the variables are not set and defaulting them to empty string when no debug components were used. Instead - we moved the debugger ports to separate compose file and only use the compose file when debug components are used.
When debugger option has been added to breeze in #51763 - the ports were added to base-port.yml, but the environment variables were only set when debugging is enabled. This hower caused warnings that the variables are not set and defaulting them to empty string when no debug components were used. Instead - we moved the debugger ports to separate compose file and only use the compose file when debug components are used.
#54051) When debugger option has been added to breeze in #51763 - the ports were added to base-port.yml, but the environment variables were only set when debugging is enabled. This hower caused warnings that the variables are not set and defaulting them to empty string when no debug components were used. Instead - we moved the debugger ports to separate compose file and only use the compose file when debug components are used. (cherry picked from commit 939700f) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
#54051) (#54053) When debugger option has been added to breeze in #51763 - the ports were added to base-port.yml, but the environment variables were only set when debugging is enabled. This hower caused warnings that the variables are not set and defaulting them to empty string when no debug components were used. Instead - we moved the debugger ports to separate compose file and only use the compose file when debug components are used. (cherry picked from commit 939700f) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
* debug support in breeze * fix celery env var * Add debug options for Airflow components and update related constants * Add debug options for Airflow components and update related constants * refactor * update documentation and add setup_vscode * Remove section on overriding default debug ports in VSCode setup documentation * fix base-ports * fix base-ports * update docs * add webserver details in docs * update docs * update docs * update docs (cherry picked from commit 55d648e)
) When debugger option has been added to breeze in apache#51763 - the ports were added to base-port.yml, but the environment variables were only set when debugging is enabled. This hower caused warnings that the variables are not set and defaulting them to empty string when no debug components were used. Instead - we moved the debugger ports to separate compose file and only use the compose file when debug components are used.
) When debugger option has been added to breeze in apache#51763 - the ports were added to base-port.yml, but the environment variables were only set when debugging is enabled. This hower caused warnings that the variables are not set and defaulting them to empty string when no debug components were used. Instead - we moved the debugger ports to separate compose file and only use the compose file when debug components are used.
Using debugpy to run airflow components so that we can use IDE's as Vscode to attach to the component to debug.
Refer to contributing-docs/20_debugging_airflow_components.rst for debug guide
Ports for components are as follows:
Also added
setup_vscode.pywhich will generate debug configuration in.vscode/launch.json.As of now, I added support only for debugpy with VS code. I haven't used PyCharm much and tried to make it work with pydevd-pycharm. But, unable to.
EDIT: Used cursor to generate the documentation. but, I reviewed it twice removing most of the unnecessary stuff.